93e1476a0f
- Fix target delete URL path mismatch (/targets/ -> /target/) - Implement target create/delete server handlers with proper validation - Add DeleteTarget method with force flag and mutex locking to SCSITargetService - Implement full LU management: create/list/delete through CLI, client, and server - Add TPGT list command to show target portal group tags - Add unit tests for target/LU router handlers and SCSI service Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
101 lines
2.7 KiB
Go
101 lines
2.7 KiB
Go
/*
|
|
Copyright 2016 The GoStor Authors All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/gostor/gotgt/pkg/api"
|
|
"github.com/gostor/gotgt/pkg/api/client"
|
|
"github.com/spf13/cobra"
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
func newRemoveCommand(cli *client.Client) *cobra.Command {
|
|
var cmd = &cobra.Command{
|
|
Use: "rm",
|
|
Short: "Remove an object",
|
|
Long: `All software has versions. This is Gotgt 's`,
|
|
Run: func(cmd *cobra.Command, args []string) {
|
|
fmt.Println(cmd.UsageString())
|
|
},
|
|
}
|
|
cmd.AddCommand(
|
|
newRemoveTargetCmd(cli),
|
|
newRemoveLuCmd(cli),
|
|
)
|
|
return cmd
|
|
}
|
|
|
|
func newRemoveTargetCmd(cli *client.Client) *cobra.Command {
|
|
opts := api.TargetRemoveOptions{}
|
|
var cmd = &cobra.Command{
|
|
Use: "target",
|
|
Short: "Remove a target from gotgt",
|
|
Long: `All software has versions. This is Gotgt 's`,
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
return removeTarget(cli, opts)
|
|
},
|
|
}
|
|
flags := cmd.Flags()
|
|
flags.StringVar(&opts.Name, "name", "", "Specify target name")
|
|
flags.BoolVar(&opts.Force, "force", false, "Force removal even with active sessions")
|
|
|
|
return cmd
|
|
|
|
}
|
|
|
|
func newRemoveLuCmd(cli *client.Client) *cobra.Command {
|
|
opts := api.LuRemoveOptions{}
|
|
var cmd = &cobra.Command{
|
|
Use: "lu",
|
|
Short: "Remove a LU from gotgt",
|
|
Long: `Remove a Logical Unit from a target`,
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
if err := NoArgs(cmd, args); err != nil {
|
|
return err
|
|
}
|
|
return removeLu(cli, opts)
|
|
},
|
|
}
|
|
flags := cmd.Flags()
|
|
flags.StringVar(&opts.TargetName, "target", "", "Specify target name")
|
|
flags.Uint64Var(&opts.LUN, "lun", 0, "Specify LUN number")
|
|
return cmd
|
|
}
|
|
|
|
func removeTarget(cli *client.Client, opts api.TargetRemoveOptions) error {
|
|
err := cli.TargetRemove(context.Background(), opts)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fmt.Printf("Target %s successfully removed\n", opts.Name)
|
|
return nil
|
|
}
|
|
|
|
func removeLu(cli *client.Client, opts api.LuRemoveOptions) error {
|
|
if opts.TargetName == "" {
|
|
return fmt.Errorf("target name is required (--target)")
|
|
}
|
|
err := cli.LuRemove(context.Background(), opts)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fmt.Printf("LU %d successfully removed from target %s\n", opts.LUN, opts.TargetName)
|
|
return nil
|
|
}
|