Use const/let in specs, not var

This commit is contained in:
Steve Gravrock
2022-04-16 13:41:44 -07:00
parent 482dc883eb
commit 1166d10e43
111 changed files with 2522 additions and 2675 deletions
+63 -51
View File
@@ -1,6 +1,6 @@
describe('FakeDate', function() {
it('does not fail if no global date is found', function() {
var fakeGlobal = {},
const fakeGlobal = {},
mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
expect(function() {
@@ -11,11 +11,13 @@ describe('FakeDate', function() {
});
it('replaces the global Date when it is installed', function() {
var globalDate = jasmine.createSpy('global Date').and.callFake(function() {
return {
getTime: function() {}
};
}),
const globalDate = jasmine
.createSpy('global Date')
.and.callFake(function() {
return {
getTime: function() {}
};
}),
fakeGlobal = { Date: globalDate },
mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
@@ -26,11 +28,13 @@ describe('FakeDate', function() {
});
it('replaces the global Date on uninstall', function() {
var globalDate = jasmine.createSpy('global Date').and.callFake(function() {
return {
getTime: function() {}
};
}),
const globalDate = jasmine
.createSpy('global Date')
.and.callFake(function() {
return {
getTime: function() {}
};
}),
fakeGlobal = { Date: globalDate },
mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
@@ -41,13 +45,15 @@ describe('FakeDate', function() {
});
it('takes the current time as the base when installing without parameters', function() {
var globalDate = jasmine.createSpy('global Date').and.callFake(function() {
return {
getTime: function() {
return 1000;
}
};
}),
const globalDate = jasmine
.createSpy('global Date')
.and.callFake(function() {
return {
getTime: function() {
return 1000;
}
};
}),
fakeGlobal = { Date: globalDate },
mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
@@ -59,7 +65,7 @@ describe('FakeDate', function() {
});
it('can accept a date as time base when installing', function() {
var fakeGlobal = { Date: Date },
const fakeGlobal = { Date: Date },
mockDate = new jasmineUnderTest.MockDate(fakeGlobal),
baseDate = new Date();
@@ -70,7 +76,7 @@ describe('FakeDate', function() {
});
it('makes real dates', function() {
var fakeGlobal = { Date: Date },
const fakeGlobal = { Date: Date },
mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
mockDate.install();
@@ -79,17 +85,19 @@ describe('FakeDate', function() {
});
it('fakes current time when using Date.now()', function() {
var globalDate = jasmine.createSpy('global Date').and.callFake(function() {
return {
getTime: function() {
return 1000;
}
};
}),
const globalDate = jasmine
.createSpy('global Date')
.and.callFake(function() {
return {
getTime: function() {
return 1000;
}
};
}),
fakeGlobal = { Date: globalDate };
globalDate.now = function() {};
var mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
const mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
mockDate.install();
@@ -97,17 +105,19 @@ describe('FakeDate', function() {
});
it('makes time passes using tick', function() {
var globalDate = jasmine.createSpy('global Date').and.callFake(function() {
return {
getTime: function() {
return 1000;
}
};
}),
const globalDate = jasmine
.createSpy('global Date')
.and.callFake(function() {
return {
getTime: function() {
return 1000;
}
};
}),
fakeGlobal = { Date: globalDate };
globalDate.now = function() {};
var mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
const mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
mockDate.install();
@@ -121,17 +131,19 @@ describe('FakeDate', function() {
});
it('allows to increase 0 milliseconds using tick', function() {
var globalDate = jasmine.createSpy('global Date').and.callFake(function() {
return {
getTime: function() {
return 1000;
}
};
}),
const globalDate = jasmine
.createSpy('global Date')
.and.callFake(function() {
return {
getTime: function() {
return 1000;
}
};
}),
fakeGlobal = { Date: globalDate };
globalDate.now = function() {};
var mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
const mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
mockDate.install();
@@ -143,40 +155,40 @@ describe('FakeDate', function() {
});
it('allows creation of a Date in a different time than the mocked time', function() {
var fakeGlobal = { Date: Date },
const fakeGlobal = { Date: Date },
mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
mockDate.install();
var otherDate = new fakeGlobal.Date(2013, 9, 23, 0, 0, 1, 0);
const otherDate = new fakeGlobal.Date(2013, 9, 23, 0, 0, 1, 0);
expect(otherDate.getTime()).toEqual(
new Date(2013, 9, 23, 0, 0, 1, 0).getTime()
);
});
it("allows creation of a Date that isn't fully specified", function() {
var fakeGlobal = { Date: Date },
const fakeGlobal = { Date: Date },
mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
mockDate.install();
var otherDate = new fakeGlobal.Date(2013, 9, 23);
const otherDate = new fakeGlobal.Date(2013, 9, 23);
expect(otherDate.getTime()).toEqual(new Date(2013, 9, 23).getTime());
});
it('allows creation of a Date with millis', function() {
var fakeGlobal = { Date: Date },
const fakeGlobal = { Date: Date },
mockDate = new jasmineUnderTest.MockDate(fakeGlobal),
now = new Date(2014, 3, 15).getTime();
mockDate.install();
var otherDate = new fakeGlobal.Date(now);
const otherDate = new fakeGlobal.Date(now);
expect(otherDate.getTime()).toEqual(now);
});
it('copies all Date properties to the mocked date', function() {
var fakeGlobal = { Date: Date },
const fakeGlobal = { Date: Date },
mockDate = new jasmineUnderTest.MockDate(fakeGlobal);
mockDate.install();