Add checkbox to test runner which toggles catching of exceptions during tests

This commit is contained in:
Alex Kwiatkowski
2012-04-15 17:45:50 -04:00
parent 2385acedd8
commit 1771ec3c63
9 changed files with 205 additions and 67 deletions
+77 -12
View File
@@ -78,6 +78,7 @@ jasmine.HtmlReporter = function(_doc) {
createReporterDom(runner.env.versionString()); createReporterDom(runner.env.versionString());
doc.body.appendChild(dom.reporter); doc.body.appendChild(dom.reporter);
setExceptionHandling();
reporterView = new jasmine.HtmlReporter.ReporterView(dom); reporterView = new jasmine.HtmlReporter.ReporterView(dom);
reporterView.addSpecs(specs, self.specFilter); reporterView.addSpecs(specs, self.specFilter);
@@ -131,7 +132,7 @@ jasmine.HtmlReporter = function(_doc) {
} }
var paramMap = []; var paramMap = [];
var params = doc.location.search.substring(1).split('&'); var params = jasmine.HtmlReporter.parameters(doc);
for (var i = 0; i < params.length; i++) { for (var i = 0; i < params.length; i++) {
var p = params[i].split('='); var p = params[i].split('=');
@@ -151,14 +152,78 @@ jasmine.HtmlReporter = function(_doc) {
self.createDom('span', { className: 'version' }, version)), self.createDom('span', { className: 'version' }, version)),
dom.symbolSummary = self.createDom('ul', {className: 'symbolSummary'}), dom.symbolSummary = self.createDom('ul', {className: 'symbolSummary'}),
dom.alert = self.createDom('div', {className: 'alert'}), dom.alert = self.createDom('div', {className: 'alert'},
self.createDom('span', { className: 'exceptions' },
self.createDom('label', { className: 'label', for: 'no_try_catch' }, 'No try/catch'),
self.createDom('input', { id: 'no_try_catch', type: 'checkbox' }))),
dom.results = self.createDom('div', {className: 'results'}, dom.results = self.createDom('div', {className: 'results'},
dom.summary = self.createDom('div', { className: 'summary' }), dom.summary = self.createDom('div', { className: 'summary' }),
dom.details = self.createDom('div', { id: 'details' })) dom.details = self.createDom('div', { id: 'details' }))
); );
} }
function noTryCatch() {
return window.location.search.match(/catch=false/);
}
function searchWithCatch() {
var params = jasmine.HtmlReporter.parameters(window.document);
var removed = false;
var i = 0;
while (!removed && i < params.length) {
if (params[i].match(/catch=/)) {
params.splice(i, 1);
removed = true;
}
i++;
}
if (jasmine.CATCH_EXCEPTIONS) {
params.push("catch=false");
}
return params.join("&");
}
function setExceptionHandling() {
var chxCatch = document.getElementById('no_try_catch');
if (noTryCatch()) {
chxCatch.setAttribute('checked', true);
jasmine.CATCH_EXCEPTIONS = false;
}
chxCatch.onclick = function() {
window.location.search = searchWithCatch();
};
}
}; };
jasmine.HtmlReporterHelpers.addHelpers(jasmine.HtmlReporter);jasmine.HtmlReporter.ReporterView = function(dom) { jasmine.HtmlReporter.parameters = function(doc) {
var paramStr = doc.location.search.substring(1);
var params = [];
if (paramStr.length > 0) {
params = paramStr.split('&');
}
return params;
}
jasmine.HtmlReporter.sectionLink = function(sectionName) {
var link = '?';
var params = [];
if (sectionName) {
params.push('spec=' + encodeURIComponent(sectionName));
}
if (!jasmine.CATCH_EXCEPTIONS) {
params.push("catch=false");
}
if (params.length > 0) {
link += params.join("&");
}
return link;
};
jasmine.HtmlReporterHelpers.addHelpers(jasmine.HtmlReporter);
jasmine.HtmlReporter.ReporterView = function(dom) {
this.startedAt = new Date(); this.startedAt = new Date();
this.runningSpecCount = 0; this.runningSpecCount = 0;
this.completeSpecCount = 0; this.completeSpecCount = 0;
@@ -241,14 +306,14 @@ jasmine.HtmlReporterHelpers.addHelpers(jasmine.HtmlReporter);jasmine.HtmlReporte
// currently running UI // currently running UI
if (isUndefined(this.runningAlert)) { if (isUndefined(this.runningAlert)) {
this.runningAlert = this.createDom('a', {href: "?", className: "runningAlert bar"}); this.runningAlert = this.createDom('a', { href: jasmine.HtmlReporter.sectionLink(), className: "runningAlert bar" });
dom.alert.appendChild(this.runningAlert); dom.alert.appendChild(this.runningAlert);
} }
this.runningAlert.innerHTML = "Running " + this.completeSpecCount + " of " + specPluralizedFor(this.totalSpecCount); this.runningAlert.innerHTML = "Running " + this.completeSpecCount + " of " + specPluralizedFor(this.totalSpecCount);
// skipped specs UI // skipped specs UI
if (isUndefined(this.skippedAlert)) { if (isUndefined(this.skippedAlert)) {
this.skippedAlert = this.createDom('a', {href: "?", className: "skippedAlert bar"}); this.skippedAlert = this.createDom('a', { href: jasmine.HtmlReporter.sectionLink(), className: "skippedAlert bar" });
} }
this.skippedAlert.innerHTML = "Skipping " + this.skippedCount + " of " + specPluralizedFor(this.totalSpecCount) + " - run all"; this.skippedAlert.innerHTML = "Skipping " + this.skippedCount + " of " + specPluralizedFor(this.totalSpecCount) + " - run all";
@@ -259,7 +324,7 @@ jasmine.HtmlReporterHelpers.addHelpers(jasmine.HtmlReporter);jasmine.HtmlReporte
// passing specs UI // passing specs UI
if (isUndefined(this.passedAlert)) { if (isUndefined(this.passedAlert)) {
this.passedAlert = this.createDom('span', {href: "?", className: "passingAlert bar"}); this.passedAlert = this.createDom('span', { href: jasmine.HtmlReporter.sectionLink(), className: "passingAlert bar" });
} }
this.passedAlert.innerHTML = "Passing " + specPluralizedFor(this.passedCount); this.passedAlert.innerHTML = "Passing " + specPluralizedFor(this.passedCount);
@@ -331,11 +396,11 @@ jasmine.HtmlReporter.SpecView = function(spec, dom, views) {
this.dom.symbolSummary.appendChild(this.symbol); this.dom.symbolSummary.appendChild(this.symbol);
this.summary = this.createDom('div', { className: 'specSummary' }, this.summary = this.createDom('div', { className: 'specSummary' },
this.createDom('a', { this.createDom('a', {
className: 'description', className: 'description',
href: '?spec=' + encodeURIComponent(this.spec.getFullName()), href: jasmine.HtmlReporter.sectionLink(this.spec.getFullName()),
title: this.spec.getFullName() title: this.spec.getFullName()
}, this.spec.description) }, this.spec.description)
); );
this.detail = this.createDom('div', { className: 'specDetail' }, this.detail = this.createDom('div', { className: 'specDetail' },
@@ -406,7 +471,7 @@ jasmine.HtmlReporterHelpers.addHelpers(jasmine.HtmlReporter.SpecView);jasmine.Ht
this.views = views; this.views = views;
this.element = this.createDom('div', { className: 'suite' }, this.element = this.createDom('div', { className: 'suite' },
this.createDom('a', { className: 'description', href: '?spec=' + encodeURIComponent(this.suite.getFullName()) }, this.suite.description) this.createDom('a', { className: 'description', href: jasmine.HtmlReporter.sectionLink(this.suite.getFullName()) }, this.suite.description)
); );
this.appendToSummary(this.suite, this.element); this.appendToSummary(this.suite, this.element);
+1
View File
@@ -19,6 +19,7 @@ body { background-color: #eeeeee; padding: 0; margin: 5px; overflow-y: scroll; }
#HTMLReporter .symbolSummary li.skipped:before { color: #bababa; content: "\02022"; } #HTMLReporter .symbolSummary li.skipped:before { color: #bababa; content: "\02022"; }
#HTMLReporter .symbolSummary li.pending { line-height: 11px; } #HTMLReporter .symbolSummary li.pending { line-height: 11px; }
#HTMLReporter .symbolSummary li.pending:before { color: #aaaaaa; content: "-"; } #HTMLReporter .symbolSummary li.pending:before { color: #aaaaaa; content: "-"; }
#HTMLReporter .exceptions { color: #fff; float: right; margin-top: 5px; margin-right: 5px; }
#HTMLReporter .bar { line-height: 28px; font-size: 14px; display: block; color: #eee; } #HTMLReporter .bar { line-height: 28px; font-size: 14px; display: block; color: #eee; }
#HTMLReporter .runningAlert { background-color: #666666; } #HTMLReporter .runningAlert { background-color: #666666; }
#HTMLReporter .skippedAlert { background-color: #aaaaaa; } #HTMLReporter .skippedAlert { background-color: #aaaaaa; }
+1 -1
View File
@@ -2537,5 +2537,5 @@ jasmine.version_= {
"major": 1, "major": 1,
"minor": 2, "minor": 2,
"build": 0, "build": 0,
"revision": 1337005947 "revision": 1337006083
}; };
+67 -3
View File
@@ -18,6 +18,7 @@ jasmine.HtmlReporter = function(_doc) {
createReporterDom(runner.env.versionString()); createReporterDom(runner.env.versionString());
doc.body.appendChild(dom.reporter); doc.body.appendChild(dom.reporter);
setExceptionHandling();
reporterView = new jasmine.HtmlReporter.ReporterView(dom); reporterView = new jasmine.HtmlReporter.ReporterView(dom);
reporterView.addSpecs(specs, self.specFilter); reporterView.addSpecs(specs, self.specFilter);
@@ -71,7 +72,7 @@ jasmine.HtmlReporter = function(_doc) {
} }
var paramMap = []; var paramMap = [];
var params = doc.location.search.substring(1).split('&'); var params = jasmine.HtmlReporter.parameters(doc);
for (var i = 0; i < params.length; i++) { for (var i = 0; i < params.length; i++) {
var p = params[i].split('='); var p = params[i].split('=');
@@ -91,11 +92,74 @@ jasmine.HtmlReporter = function(_doc) {
self.createDom('span', { className: 'version' }, version)), self.createDom('span', { className: 'version' }, version)),
dom.symbolSummary = self.createDom('ul', {className: 'symbolSummary'}), dom.symbolSummary = self.createDom('ul', {className: 'symbolSummary'}),
dom.alert = self.createDom('div', {className: 'alert'}), dom.alert = self.createDom('div', {className: 'alert'},
self.createDom('span', { className: 'exceptions' },
self.createDom('label', { className: 'label', for: 'no_try_catch' }, 'No try/catch'),
self.createDom('input', { id: 'no_try_catch', type: 'checkbox' }))),
dom.results = self.createDom('div', {className: 'results'}, dom.results = self.createDom('div', {className: 'results'},
dom.summary = self.createDom('div', { className: 'summary' }), dom.summary = self.createDom('div', { className: 'summary' }),
dom.details = self.createDom('div', { id: 'details' })) dom.details = self.createDom('div', { id: 'details' }))
); );
} }
function noTryCatch() {
return window.location.search.match(/catch=false/);
}
function searchWithCatch() {
var params = jasmine.HtmlReporter.parameters(window.document);
var removed = false;
var i = 0;
while (!removed && i < params.length) {
if (params[i].match(/catch=/)) {
params.splice(i, 1);
removed = true;
}
i++;
}
if (jasmine.CATCH_EXCEPTIONS) {
params.push("catch=false");
}
return params.join("&");
}
function setExceptionHandling() {
var chxCatch = document.getElementById('no_try_catch');
if (noTryCatch()) {
chxCatch.setAttribute('checked', true);
jasmine.CATCH_EXCEPTIONS = false;
}
chxCatch.onclick = function() {
window.location.search = searchWithCatch();
};
}
}; };
jasmine.HtmlReporterHelpers.addHelpers(jasmine.HtmlReporter); jasmine.HtmlReporter.parameters = function(doc) {
var paramStr = doc.location.search.substring(1);
var params = [];
if (paramStr.length > 0) {
params = paramStr.split('&');
}
return params;
}
jasmine.HtmlReporter.sectionLink = function(sectionName) {
var link = '?';
var params = [];
if (sectionName) {
params.push('spec=' + encodeURIComponent(sectionName));
}
if (!jasmine.CATCH_EXCEPTIONS) {
params.push("catch=false");
}
if (params.length > 0) {
link += params.join("&");
}
return link;
};
jasmine.HtmlReporterHelpers.addHelpers(jasmine.HtmlReporter);
+3 -3
View File
@@ -81,14 +81,14 @@ jasmine.HtmlReporter.ReporterView = function(dom) {
// currently running UI // currently running UI
if (isUndefined(this.runningAlert)) { if (isUndefined(this.runningAlert)) {
this.runningAlert = this.createDom('a', {href: "?", className: "runningAlert bar"}); this.runningAlert = this.createDom('a', { href: jasmine.HtmlReporter.sectionLink(), className: "runningAlert bar" });
dom.alert.appendChild(this.runningAlert); dom.alert.appendChild(this.runningAlert);
} }
this.runningAlert.innerHTML = "Running " + this.completeSpecCount + " of " + specPluralizedFor(this.totalSpecCount); this.runningAlert.innerHTML = "Running " + this.completeSpecCount + " of " + specPluralizedFor(this.totalSpecCount);
// skipped specs UI // skipped specs UI
if (isUndefined(this.skippedAlert)) { if (isUndefined(this.skippedAlert)) {
this.skippedAlert = this.createDom('a', {href: "?", className: "skippedAlert bar"}); this.skippedAlert = this.createDom('a', { href: jasmine.HtmlReporter.sectionLink(), className: "skippedAlert bar" });
} }
this.skippedAlert.innerHTML = "Skipping " + this.skippedCount + " of " + specPluralizedFor(this.totalSpecCount) + " - run all"; this.skippedAlert.innerHTML = "Skipping " + this.skippedCount + " of " + specPluralizedFor(this.totalSpecCount) + " - run all";
@@ -99,7 +99,7 @@ jasmine.HtmlReporter.ReporterView = function(dom) {
// passing specs UI // passing specs UI
if (isUndefined(this.passedAlert)) { if (isUndefined(this.passedAlert)) {
this.passedAlert = this.createDom('span', {href: "?", className: "passingAlert bar"}); this.passedAlert = this.createDom('span', { href: jasmine.HtmlReporter.sectionLink(), className: "passingAlert bar" });
} }
this.passedAlert.innerHTML = "Passing " + specPluralizedFor(this.passedCount); this.passedAlert.innerHTML = "Passing " + specPluralizedFor(this.passedCount);
+5 -5
View File
@@ -7,11 +7,11 @@ jasmine.HtmlReporter.SpecView = function(spec, dom, views) {
this.dom.symbolSummary.appendChild(this.symbol); this.dom.symbolSummary.appendChild(this.symbol);
this.summary = this.createDom('div', { className: 'specSummary' }, this.summary = this.createDom('div', { className: 'specSummary' },
this.createDom('a', { this.createDom('a', {
className: 'description', className: 'description',
href: '?spec=' + encodeURIComponent(this.spec.getFullName()), href: jasmine.HtmlReporter.sectionLink(this.spec.getFullName()),
title: this.spec.getFullName() title: this.spec.getFullName()
}, this.spec.description) }, this.spec.description)
); );
this.detail = this.createDom('div', { className: 'specDetail' }, this.detail = this.createDom('div', { className: 'specDetail' },
+1 -1
View File
@@ -4,7 +4,7 @@ jasmine.HtmlReporter.SuiteView = function(suite, dom, views) {
this.views = views; this.views = views;
this.element = this.createDom('div', { className: 'suite' }, this.element = this.createDom('div', { className: 'suite' },
this.createDom('a', { className: 'description', href: '?spec=' + encodeURIComponent(this.suite.getFullName()) }, this.suite.description) this.createDom('a', { className: 'description', href: jasmine.HtmlReporter.sectionLink(this.suite.getFullName()) }, this.suite.description)
); );
this.appendToSummary(this.suite, this.element); this.appendToSummary(this.suite, this.element);
+49 -42
View File
@@ -136,167 +136,174 @@ body {
} }
} }
} }
.exceptions {
color: #fff;
float: right;
margin-top: 5px;
margin-right: 5px;
}
//--- Alert ---// //--- Alert ---//
.bar { .bar {
line-height: $line-height * 2; line-height: $line-height * 2;
font-size: $large-font-size; font-size: $large-font-size;
display: block; display: block;
color: #eee; color: #eee;
} }
.runningAlert { .runningAlert {
background-color: $light-text-color; background-color: $light-text-color;
} }
.skippedAlert { .skippedAlert {
background-color: $feint-text-color; background-color: $feint-text-color;
&:first-child { &:first-child {
background-color: $text-color; background-color: $text-color;
} }
&:hover { &:hover {
text-decoration: none; text-decoration: none;
color: white; color: white;
text-decoration: underline; text-decoration: underline;
} }
} }
.passingAlert { .passingAlert {
background-color: $light-passing-color; background-color: $light-passing-color;
&:first-child { &:first-child {
background-color: $passing-color; background-color: $passing-color;
} }
} }
.failingAlert { .failingAlert {
background-color: $light-failing-color; background-color: $light-failing-color;
&:first-child { &:first-child {
background-color: $failing-color background-color: $failing-color
} }
} }
//--- Results ---// //--- Results ---//
.results { .results {
margin-top: $line-height; margin-top: $line-height;
} }
//--- Results menu ---// //--- Results menu ---//
#details { #details {
display: none; display: none;
} }
.resultsMenu, .resultsMenu,
.resultsMenu a { .resultsMenu a {
background-color: #fff; background-color: #fff;
color: $text-color; color: $text-color;
} }
&.showDetails { &.showDetails {
.summaryMenuItem { .summaryMenuItem {
font-weight: normal; font-weight: normal;
text-decoration: inherit; text-decoration: inherit;
&:hover { &:hover {
text-decoration: underline; text-decoration: underline;
} }
} }
.detailsMenuItem { .detailsMenuItem {
font-weight: bold; font-weight: bold;
text-decoration: underline; text-decoration: underline;
} }
.summary { .summary {
display: none; display: none;
} }
#details { #details {
display: block; display: block;
} }
} }
.summaryMenuItem { .summaryMenuItem {
font-weight: bold; font-weight: bold;
text-decoration: underline; text-decoration: underline;
} }
//--- Results summary ---// //--- Results summary ---//
.summary { .summary {
margin-top: $margin-unit; margin-top: $margin-unit;
.suite .suite, .specSummary { .suite .suite, .specSummary {
margin-left: $margin-unit; margin-left: $margin-unit;
} }
.specSummary { .specSummary {
&.passed a { &.passed a {
color: $passing-color; color: $passing-color;
} }
&.failed a { &.failed a {
color: $failing-color; color: $failing-color;
} }
} }
} }
.description+.suite { .description+.suite {
margin-top: 0; margin-top: 0;
} }
.suite { .suite {
margin-top: $margin-unit; margin-top: $margin-unit;
a { a {
color: $text-color; color: $text-color;
} }
} }
//--- Results details ---// //--- Results details ---//
#details { #details {
.specDetail { .specDetail {
margin-bottom: $line-height * 2; margin-bottom: $line-height * 2;
.description { .description {
//line-height: $line-height * 2; //line-height: $line-height * 2;
display: block; display: block;
color: white; color: white;
background-color: $failing-color; background-color: $failing-color;
//font-size: $large-font-size; //font-size: $large-font-size;
} }
} }
} }
.resultMessage { .resultMessage {
padding-top: $line-height; padding-top: $line-height;
color: $text-color; color: $text-color;
} }
.resultMessage span.result { .resultMessage span.result {
display: block; display: block;
} }
.stackTrace { .stackTrace {
margin: 5px 0 0 0; margin: 5px 0 0 0;
max-height: $line-height * 16; max-height: $line-height * 16;
overflow: auto; overflow: auto;
line-height: 18px; line-height: 18px;
color: $light-text-color; color: $light-text-color;
border: 1px solid #ddd; border: 1px solid #ddd;
background: white; background: white;
white-space: pre; white-space: pre;
} }
} }
+1
View File
@@ -19,6 +19,7 @@ body { background-color: #eeeeee; padding: 0; margin: 5px; overflow-y: scroll; }
#HTMLReporter .symbolSummary li.skipped:before { color: #bababa; content: "\02022"; } #HTMLReporter .symbolSummary li.skipped:before { color: #bababa; content: "\02022"; }
#HTMLReporter .symbolSummary li.pending { line-height: 11px; } #HTMLReporter .symbolSummary li.pending { line-height: 11px; }
#HTMLReporter .symbolSummary li.pending:before { color: #aaaaaa; content: "-"; } #HTMLReporter .symbolSummary li.pending:before { color: #aaaaaa; content: "-"; }
#HTMLReporter .exceptions { color: #fff; float: right; margin-top: 5px; margin-right: 5px; }
#HTMLReporter .bar { line-height: 28px; font-size: 14px; display: block; color: #eee; } #HTMLReporter .bar { line-height: 28px; font-size: 14px; display: block; color: #eee; }
#HTMLReporter .runningAlert { background-color: #666666; } #HTMLReporter .runningAlert { background-color: #666666; }
#HTMLReporter .skippedAlert { background-color: #aaaaaa; } #HTMLReporter .skippedAlert { background-color: #aaaaaa; }