diff --git a/GOALS_2.0.md b/GOALS_2.0.md index 9198a116..30244b98 100644 --- a/GOALS_2.0.md +++ b/GOALS_2.0.md @@ -16,6 +16,12 @@ * Finish killing Globals * Guidelines: everything that isn't a CTOR should be closed inside `Env`, and everything that is a CTOR needs to be `new`ed inside the `Env` * Spies + * isA functions: + * isArray_ - used in matchers and spies + * isString_ + * isDOMNode_ + * isA_ + * unimplementedMethod_, used by PrettyPrinter * jasmine.util should be util closure inside of env or something * argsToArray is used for Spies and matching * inherit is for how matchers are added/mixed in, reporters, and pretty printers diff --git a/lib/jasmine-core/jasmine.js b/lib/jasmine-core/jasmine.js index 59199582..8ad75ad9 100644 --- a/lib/jasmine-core/jasmine.js +++ b/lib/jasmine-core/jasmine.js @@ -5,6 +5,8 @@ * @namespace */ var jasmine = {}; + +// TODO: do we need this now that we have boot.js? if (typeof window == "undefined" && typeof exports == "object") { exports.jasmine = jasmine } @@ -24,12 +26,6 @@ jasmine.unimplementedMethod_ = function() { */ jasmine.undefined = jasmine.___undefined___; -/** - * Show diagnostic messages in the console if set to true - * - */ -jasmine.VERBOSE = false; - /** * Default interval in milliseconds for event loop yields (e.g. to allow network activity or to refresh the screen with the HTML-based runner). Small values here may result in slow test running. Zero means no updates until all tests have completed. * @@ -443,9 +439,7 @@ jasmine.util.argsToArray = function(args) { var arrayOfArgs = []; for (var i = 0; i < args.length; i++) arrayOfArgs.push(args[i]); return arrayOfArgs; -}; - -//TODO: expectation result may make more sense as a presentation of an expectation. +};//TODO: expectation result may make more sense as a presentation of an expectation. jasmine.buildExpectationResult = function(params) { return { type: 'expect', diff --git a/src/core/base.js b/src/core/base.js index c8d631fe..aab02e95 100644 --- a/src/core/base.js +++ b/src/core/base.js @@ -5,6 +5,8 @@ * @namespace */ var jasmine = {}; + +// TODO: do we need this now that we have boot.js? if (typeof window == "undefined" && typeof exports == "object") { exports.jasmine = jasmine } @@ -24,12 +26,6 @@ jasmine.unimplementedMethod_ = function() { */ jasmine.undefined = jasmine.___undefined___; -/** - * Show diagnostic messages in the console if set to true - * - */ -jasmine.VERBOSE = false; - /** * Default interval in milliseconds for event loop yields (e.g. to allow network activity or to refresh the screen with the HTML-based runner). Small values here may result in slow test running. Zero means no updates until all tests have completed. *