Use one declaration per statement
The old style of merging all of a function's variable declarations into a single statement made some sense back in the days of var, but there's no reason to keep doing it now that we use const and let.
This commit is contained in:
@@ -2,13 +2,13 @@ describe('QueryString', function() {
|
||||
describe('#navigateWithNewParam', function() {
|
||||
it('sets the query string to include the given key/value pair', function() {
|
||||
const windowLocation = {
|
||||
search: ''
|
||||
},
|
||||
queryString = new jasmineUnderTest.QueryString({
|
||||
getWindowLocation: function() {
|
||||
return windowLocation;
|
||||
}
|
||||
});
|
||||
search: ''
|
||||
};
|
||||
const queryString = new jasmineUnderTest.QueryString({
|
||||
getWindowLocation: function() {
|
||||
return windowLocation;
|
||||
}
|
||||
});
|
||||
|
||||
queryString.navigateWithNewParam('foo', 'bar baz');
|
||||
|
||||
@@ -17,13 +17,13 @@ describe('QueryString', function() {
|
||||
|
||||
it('leaves existing params alone', function() {
|
||||
const windowLocation = {
|
||||
search: '?foo=bar'
|
||||
},
|
||||
queryString = new jasmineUnderTest.QueryString({
|
||||
getWindowLocation: function() {
|
||||
return windowLocation;
|
||||
}
|
||||
});
|
||||
search: '?foo=bar'
|
||||
};
|
||||
const queryString = new jasmineUnderTest.QueryString({
|
||||
getWindowLocation: function() {
|
||||
return windowLocation;
|
||||
}
|
||||
});
|
||||
|
||||
queryString.navigateWithNewParam('baz', 'quux');
|
||||
|
||||
@@ -35,13 +35,13 @@ describe('QueryString', function() {
|
||||
describe('#fullStringWithNewParam', function() {
|
||||
it('gets the query string including the given key/value pair', function() {
|
||||
const windowLocation = {
|
||||
search: '?foo=bar'
|
||||
},
|
||||
queryString = new jasmineUnderTest.QueryString({
|
||||
getWindowLocation: function() {
|
||||
return windowLocation;
|
||||
}
|
||||
});
|
||||
search: '?foo=bar'
|
||||
};
|
||||
const queryString = new jasmineUnderTest.QueryString({
|
||||
getWindowLocation: function() {
|
||||
return windowLocation;
|
||||
}
|
||||
});
|
||||
|
||||
const result = queryString.fullStringWithNewParam('baz', 'quux');
|
||||
|
||||
@@ -53,26 +53,26 @@ describe('QueryString', function() {
|
||||
describe('#getParam', function() {
|
||||
it('returns the value of the requested key', function() {
|
||||
const windowLocation = {
|
||||
search: '?baz=quux%20corge'
|
||||
},
|
||||
queryString = new jasmineUnderTest.QueryString({
|
||||
getWindowLocation: function() {
|
||||
return windowLocation;
|
||||
}
|
||||
});
|
||||
search: '?baz=quux%20corge'
|
||||
};
|
||||
const queryString = new jasmineUnderTest.QueryString({
|
||||
getWindowLocation: function() {
|
||||
return windowLocation;
|
||||
}
|
||||
});
|
||||
|
||||
expect(queryString.getParam('baz')).toEqual('quux corge');
|
||||
});
|
||||
|
||||
it('returns null if the key is not present', function() {
|
||||
const windowLocation = {
|
||||
search: ''
|
||||
},
|
||||
queryString = new jasmineUnderTest.QueryString({
|
||||
getWindowLocation: function() {
|
||||
return windowLocation;
|
||||
}
|
||||
});
|
||||
search: ''
|
||||
};
|
||||
const queryString = new jasmineUnderTest.QueryString({
|
||||
getWindowLocation: function() {
|
||||
return windowLocation;
|
||||
}
|
||||
});
|
||||
|
||||
expect(queryString.getParam('baz')).toBeFalsy();
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user