Check for accidental global variable creation

This commit is contained in:
Steve Gravrock
2018-03-25 12:01:50 -07:00
parent 7f1cdc2d02
commit 74287c578c
9 changed files with 26 additions and 8 deletions
+10 -2
View File
@@ -1,9 +1,17 @@
{ {
"bitwise": true, "bitwise": true,
"curly": true, "curly": true,
"globals": {
"clearTimeout": false,
"console": false,
"getJasmineRequireObj": true,
"jasmineRequire": true,
"setTimeout": false
},
"immed": true, "immed": true,
"newcap": true, "newcap": true,
"trailing": true, "trailing": true,
"loopfunc": true, "loopfunc": true,
"quotmark": "single" "quotmark": "single",
} "undef": true
}
+8 -3
View File
@@ -21,6 +21,7 @@ OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/ */
var getJasmineRequireObj = (function (jasmineGlobal) { var getJasmineRequireObj = (function (jasmineGlobal) {
/* globals exports, global, module, window */
var jasmineRequire; var jasmineRequire;
if (typeof module !== 'undefined' && module.exports && typeof exports !== 'undefined') { if (typeof module !== 'undefined' && module.exports && typeof exports !== 'undefined') {
@@ -704,6 +705,7 @@ getJasmineRequireObj().Spec = function(j$) {
}; };
if (typeof window == void 0 && typeof exports == 'object') { if (typeof window == void 0 && typeof exports == 'object') {
/* globals exports */
exports.Spec = jasmineRequire.Spec; exports.Spec = jasmineRequire.Spec;
} }
@@ -1492,11 +1494,11 @@ getJasmineRequireObj().Env = function(j$) {
message += ': '; message += ': ';
if (error.message) { if (error.message) {
message += error.message; message += error.message;
} else if (jasmine.isString_(error)) { } else if (j$.isString_(error)) {
message += error; message += error;
} else { } else {
// pretty print all kind of objects. This includes arrays. // pretty print all kind of objects. This includes arrays.
message += jasmine.pp(error); message += j$.pp(error);
} }
} }
@@ -1683,6 +1685,7 @@ getJasmineRequireObj().Any = function(j$) {
} }
/* jshint -W122 */ /* jshint -W122 */
/* global Symbol */
if (typeof Symbol != 'undefined' && this.expectedObject == Symbol) { if (typeof Symbol != 'undefined' && this.expectedObject == Symbol) {
return typeof other == 'symbol'; return typeof other == 'symbol';
} }
@@ -1734,7 +1737,7 @@ getJasmineRequireObj().ArrayContaining = function(j$) {
}; };
ArrayContaining.prototype.jasmineToString = function () { ArrayContaining.prototype.jasmineToString = function () {
return '<jasmine.arrayContaining(' + jasmine.pp(this.sample) +')>'; return '<jasmine.arrayContaining(' + j$.pp(this.sample) +')>';
}; };
return ArrayContaining; return ArrayContaining;
@@ -2114,6 +2117,7 @@ getJasmineRequireObj().clearStack = function(j$) {
getJasmineRequireObj().Clock = function() { getJasmineRequireObj().Clock = function() {
/* global process */
var NODE_JS = typeof process !== 'undefined' && process.versions && typeof process.versions.node === 'string'; var NODE_JS = typeof process !== 'undefined' && process.versions && typeof process.versions.node === 'string';
/** /**
@@ -6037,6 +6041,7 @@ getJasmineRequireObj().Suite = function(j$) {
}; };
if (typeof window == void 0 && typeof exports == 'object') { if (typeof window == void 0 && typeof exports == 'object') {
/* globals exports */
exports.Suite = jasmineRequire.Suite; exports.Suite = jasmineRequire.Suite;
} }
+1
View File
@@ -1,5 +1,6 @@
getJasmineRequireObj().Clock = function() { getJasmineRequireObj().Clock = function() {
/* global process */
var NODE_JS = typeof process !== 'undefined' && process.versions && typeof process.versions.node === 'string'; var NODE_JS = typeof process !== 'undefined' && process.versions && typeof process.versions.node === 'string';
/** /**
+2 -2
View File
@@ -736,11 +736,11 @@ getJasmineRequireObj().Env = function(j$) {
message += ': '; message += ': ';
if (error.message) { if (error.message) {
message += error.message; message += error.message;
} else if (jasmine.isString_(error)) { } else if (j$.isString_(error)) {
message += error; message += error;
} else { } else {
// pretty print all kind of objects. This includes arrays. // pretty print all kind of objects. This includes arrays.
message += jasmine.pp(error); message += j$.pp(error);
} }
} }
+1
View File
@@ -177,5 +177,6 @@ getJasmineRequireObj().Spec = function(j$) {
}; };
if (typeof window == void 0 && typeof exports == 'object') { if (typeof window == void 0 && typeof exports == 'object') {
/* globals exports */
exports.Spec = jasmineRequire.Spec; exports.Spec = jasmineRequire.Spec;
} }
+1
View File
@@ -163,5 +163,6 @@ getJasmineRequireObj().Suite = function(j$) {
}; };
if (typeof window == void 0 && typeof exports == 'object') { if (typeof window == void 0 && typeof exports == 'object') {
/* globals exports */
exports.Suite = jasmineRequire.Suite; exports.Suite = jasmineRequire.Suite;
} }
+1
View File
@@ -32,6 +32,7 @@ getJasmineRequireObj().Any = function(j$) {
} }
/* jshint -W122 */ /* jshint -W122 */
/* global Symbol */
if (typeof Symbol != 'undefined' && this.expectedObject == Symbol) { if (typeof Symbol != 'undefined' && this.expectedObject == Symbol) {
return typeof other == 'symbol'; return typeof other == 'symbol';
} }
@@ -19,7 +19,7 @@ getJasmineRequireObj().ArrayContaining = function(j$) {
}; };
ArrayContaining.prototype.jasmineToString = function () { ArrayContaining.prototype.jasmineToString = function () {
return '<jasmine.arrayContaining(' + jasmine.pp(this.sample) +')>'; return '<jasmine.arrayContaining(' + j$.pp(this.sample) +')>';
}; };
return ArrayContaining; return ArrayContaining;
+1
View File
@@ -1,4 +1,5 @@
var getJasmineRequireObj = (function (jasmineGlobal) { var getJasmineRequireObj = (function (jasmineGlobal) {
/* globals exports, global, module, window */
var jasmineRequire; var jasmineRequire;
if (typeof module !== 'undefined' && module.exports && typeof exports !== 'undefined') { if (typeof module !== 'undefined' && module.exports && typeof exports !== 'undefined') {