From 87177d9d437c7d5113c599beba0343b043db4d66 Mon Sep 17 00:00:00 2001 From: Steve Gravrock Date: Sat, 17 Jan 2026 17:12:32 -0800 Subject: [PATCH] Fix browser ESM deprecation wraning Previously, the warning was issued if jasmineRequire.core was called from an ES module rather than being defined in an ES module. --- lib/jasmine-core/jasmine.js | 6 ++++-- src/core/requireCore.js | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/jasmine-core/jasmine.js b/lib/jasmine-core/jasmine.js index 89d36cfc..2c4204fb 100644 --- a/lib/jasmine-core/jasmine.js +++ b/lib/jasmine-core/jasmine.js @@ -43,6 +43,9 @@ var getJasmineRequireObj = (function() { return jasmineRequire; } + const loadedAsBrowserEsm = + globalThis.document && !globalThis.document.currentScript; + getJasmineRequire().core = function(jRequire) { const j$ = {}; Object.defineProperty(j$, 'private', { @@ -124,8 +127,7 @@ var getJasmineRequireObj = (function() { j$.private.matchers = jRequire.requireMatchers(jRequire, j$); j$.private.asyncMatchers = jRequire.requireAsyncMatchers(jRequire, j$); - j$.private.loadedAsBrowserEsm = - globalThis.document && !globalThis.document.currentScript; + j$.private.loadedAsBrowserEsm = loadedAsBrowserEsm; j$.private.deprecateMonkeyPatching(j$, [ // These are meant to be set by users. diff --git a/src/core/requireCore.js b/src/core/requireCore.js index e8b70c20..70b08ef6 100644 --- a/src/core/requireCore.js +++ b/src/core/requireCore.js @@ -19,6 +19,9 @@ var getJasmineRequireObj = (function() { return jasmineRequire; } + const loadedAsBrowserEsm = + globalThis.document && !globalThis.document.currentScript; + getJasmineRequire().core = function(jRequire) { const j$ = {}; Object.defineProperty(j$, 'private', { @@ -100,8 +103,7 @@ var getJasmineRequireObj = (function() { j$.private.matchers = jRequire.requireMatchers(jRequire, j$); j$.private.asyncMatchers = jRequire.requireAsyncMatchers(jRequire, j$); - j$.private.loadedAsBrowserEsm = - globalThis.document && !globalThis.document.currentScript; + j$.private.loadedAsBrowserEsm = loadedAsBrowserEsm; j$.private.deprecateMonkeyPatching(j$, [ // These are meant to be set by users.