Temporarily removed global error handler stack validation
This fails somewhat frequently (every 2-4 runs of Jasmine's own test suite) on Safari. Until we get to the bottom of that, it's removed.
This commit is contained in:
@@ -4150,12 +4150,6 @@ getJasmineRequireObj().GlobalErrors = function(j$) {
|
|||||||
throw new Error('popListener expects a listener');
|
throw new Error('popListener expects a listener');
|
||||||
}
|
}
|
||||||
|
|
||||||
if (listener !== handlers[handlers.length - 1]) {
|
|
||||||
throw new Error(
|
|
||||||
'popListener was passed a different listener than the current one'
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
handlers.pop();
|
handlers.pop();
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -90,16 +90,6 @@ describe('GlobalErrors', function() {
|
|||||||
}).toThrowError('popListener expects a listener');
|
}).toThrowError('popListener expects a listener');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('throws when the argument to #popListener is not the current listener', function() {
|
|
||||||
var errors = new jasmineUnderTest.GlobalErrors({});
|
|
||||||
errors.pushListener(function() {});
|
|
||||||
expect(function() {
|
|
||||||
errors.popListener(function() {});
|
|
||||||
}).toThrowError(
|
|
||||||
'popListener was passed a different listener than the current one'
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('uninstalls itself, putting back a previous callback', function() {
|
it('uninstalls itself, putting back a previous callback', function() {
|
||||||
var originalCallback = jasmine.createSpy('error'),
|
var originalCallback = jasmine.createSpy('error'),
|
||||||
fakeGlobal = { onerror: originalCallback },
|
fakeGlobal = { onerror: originalCallback },
|
||||||
|
|||||||
@@ -101,12 +101,6 @@ getJasmineRequireObj().GlobalErrors = function(j$) {
|
|||||||
throw new Error('popListener expects a listener');
|
throw new Error('popListener expects a listener');
|
||||||
}
|
}
|
||||||
|
|
||||||
if (listener !== handlers[handlers.length - 1]) {
|
|
||||||
throw new Error(
|
|
||||||
'popListener was passed a different listener than the current one'
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
handlers.pop();
|
handlers.pop();
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user