Improved resolveValue/rejectValue error messages

This commit is contained in:
Elliot Nelson
2019-05-07 16:30:48 -04:00
parent 72aa0bbe4d
commit 95e1890e64
2 changed files with 6 additions and 10 deletions
+4 -8
View File
@@ -112,9 +112,7 @@ describe("SpyStrategy", function() {
describe("#resolveValue", function() { describe("#resolveValue", function() {
it("allows a resolved promise to be returned", function(done) { it("allows a resolved promise to be returned", function(done) {
if (!jasmineUnderTest.getPromise()) { jasmine.getEnv().requirePromises();
pending('Environment does not support promises.');
}
var originalFn = jasmine.createSpy("original"), var originalFn = jasmine.createSpy("original"),
spyStrategy = new jasmineUnderTest.SpyStrategy({fn: originalFn}); spyStrategy = new jasmineUnderTest.SpyStrategy({fn: originalFn});
@@ -134,15 +132,13 @@ describe("SpyStrategy", function() {
expect(function() { expect(function() {
spyStrategy.resolveValue(37); spyStrategy.resolveValue(37);
}).toThrowError('resolveValue is unavailable because the environment does not support promises.'); }).toThrowError('resolveValue requires global Promise, or a `promiseLibrary` configured with `jasmine.getEnv().configure()`');
}); });
}); });
describe("#rejectValue", function() { describe("#rejectValue", function() {
it("allows a rejected promise to be returned", function(done) { it("allows a rejected promise to be returned", function(done) {
if (!jasmineUnderTest.getPromise()) { jasmine.getEnv().requirePromises();
pending('Environment does not support promises.');
}
var originalFn = jasmine.createSpy("original"), var originalFn = jasmine.createSpy("original"),
spyStrategy = new jasmineUnderTest.SpyStrategy({fn: originalFn}); spyStrategy = new jasmineUnderTest.SpyStrategy({fn: originalFn});
@@ -162,7 +158,7 @@ describe("SpyStrategy", function() {
expect(function() { expect(function() {
spyStrategy.rejectValue(new Error('oops')); spyStrategy.rejectValue(new Error('oops'));
}).toThrowError('rejectValue is unavailable because the environment does not support promises.'); }).toThrowError('rejectValue requires global Promise, or a `promiseLibrary` configured with `jasmine.getEnv().configure()`');
}); });
}); });
+2 -2
View File
@@ -94,7 +94,7 @@ getJasmineRequireObj().SpyStrategy = function(j$) {
var Promise = j$.getPromise(); var Promise = j$.getPromise();
if (!Promise) { if (!Promise) {
throw new Error('resolveValue is unavailable because the environment does not support promises.'); throw new Error('resolveValue requires global Promise, or a `promiseLibrary` configured with `jasmine.getEnv().configure()`');
} }
this.plan = function() { this.plan = function() {
@@ -113,7 +113,7 @@ getJasmineRequireObj().SpyStrategy = function(j$) {
var Promise = j$.getPromise(); var Promise = j$.getPromise();
if (!Promise) { if (!Promise) {
throw new Error('rejectValue is unavailable because the environment does not support promises.'); throw new Error('rejectValue requires global Promise, or a `promiseLibrary` configured with `jasmine.getEnv().configure()`');
} }
this.plan = function() { this.plan = function() {