warren/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Extracted the predicate version of toThrowError into its own matcher

Browse Source 
This simplifies the signature of each matcher to something that jsdoc
can actually handle.

[Finishes #20622765]
This commit is contained in:
Steve Gravrock
2017-11-28 09:16:09 -08:00
parent b7e4c1e779
commit 9619acf91f
6 changed files with 218 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/core/matchers/toThrowErrorSpec.js
+2 -30
View File
@@ -7,7 +7,7 @@ describe("toThrowError", function() {
}).toThrowError(/Actual is not a Function/);
});
it("throws an error when the expected is not an Error, string, RegExp, or function", function() {
it("throws an error when the expected is not an Error, string, or RegExp", function() {
var matcher = jasmineUnderTest.matchers.toThrowError(),
fn = function() {
throw new Error("foo");
@@ -15,7 +15,7 @@ describe("toThrowError", function() {
expect(function() {
matcher.compare(fn, 1);
}).toThrowError(/Expected is not an Error, string, RegExp, or Function./);
}).toThrowError(/Expected is not an Error, string, or RegExp./);
});
it("throws an error when the expected error type is not an Error", function() {
@@ -312,32 +312,4 @@ describe("toThrowError", function() {
expect(result.pass).toBe(false);
expect(result.message()).toEqual("Expected function to throw TypeError with a message matching /bar/, but it threw TypeError with message 'foo'.");
});
it("passes if the argument is a function that returns true when called with the error", function() {
var matcher = jasmineUnderTest.matchers.toThrowError(),
predicate = function(e) { return e.message === "nope" },
fn = function() {
throw new TypeError("nope");
},
result;
result = matcher.compare(fn, predicate);
expect(result.pass).toBe(true);
expect(result.message()).toEqual("Expected function not to throw an exception matching a predicate.");
});
it("fails if the argument is a function that returns false when called with the error", function() {
var matcher = jasmineUnderTest.matchers.toThrowError(),
predicate = function(e) { return e.message === "oh no" },
fn = function() {
throw new TypeError("nope");
},
result;
result = matcher.compare(fn, predicate);
expect(result.pass).toBe(false);
expect(result.message()).toEqual("Expected function to throw an exception matching a predicate, but it threw TypeError with message 'nope'.");
});
});