From b6c03a34e7d7d0f0257388229708bf920b5c6a36 Mon Sep 17 00:00:00 2001 From: Sheel Choksi Date: Mon, 17 Feb 2014 22:45:54 -0800 Subject: [PATCH] Use default failure message for toBeNaN It is providing the same functionality by default without a custom error message --- spec/core/matchers/toBeNaNSpec.js | 10 +--------- src/core/matchers/toBeNaN.js | 6 ------ 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/spec/core/matchers/toBeNaNSpec.js b/spec/core/matchers/toBeNaNSpec.js index c0cbcc5d..c1229e6a 100644 --- a/spec/core/matchers/toBeNaNSpec.js +++ b/spec/core/matchers/toBeNaNSpec.js @@ -1,11 +1,10 @@ describe("toBeNaN", function() { - it("passes for NaN with a custom .not fail", function() { + it("passes for NaN", function() { var matcher = j$.matchers.toBeNaN(), result; result = matcher.compare(Number.NaN); expect(result.pass).toBe(true); - expect(result.message).toEqual("Expected actual not to be NaN."); }); it("fails for anything not a NaN", function() { @@ -27,11 +26,4 @@ describe("toBeNaN", function() { result = matcher.compare(Number.POSITIVE_INFINITY); expect(result.pass).toBe(false); }); - - it("has a custom message on failure", function() { - var matcher = j$.matchers.toBeNaN(), - result = matcher.compare(0); - - expect(result.message).toEqual("Expected 0 to be NaN."); - }); }); diff --git a/src/core/matchers/toBeNaN.js b/src/core/matchers/toBeNaN.js index a8b0c270..f1e1b373 100644 --- a/src/core/matchers/toBeNaN.js +++ b/src/core/matchers/toBeNaN.js @@ -7,12 +7,6 @@ getJasmineRequireObj().toBeNaN = function(j$) { pass: (actual !== actual) }; - if (result.pass) { - result.message = "Expected actual not to be NaN."; - } else { - result.message = "Expected " + j$.pp(actual) + " to be NaN."; - } - return result; } };