From bbf3f6825cc5671020a03b2f5f5b20627c4feaed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andrzej=20Kope=C4=87?= <kapkowski@gmail.com>
Date: Sun, 28 Feb 2016 21:36:09 +0100
Subject: [PATCH] Improve error message when passing a non-function to callFake

---
 spec/core/SpyStrategySpec.js | 16 ++++++++++++++--
 src/core/SpyStrategy.js      |  3 +++
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/spec/core/SpyStrategySpec.js b/spec/core/SpyStrategySpec.js
index d613188d..860811b8 100644
--- a/spec/core/SpyStrategySpec.js
+++ b/spec/core/SpyStrategySpec.js
@@ -92,6 +92,18 @@ describe("SpyStrategy", function() {
     expect(returnValue).toEqual(67);
   });
 
+  it('throws an error when a non-function is passed to callFake strategy', function() {
+    var originalFn = jasmine.createSpy('original'),
+        invalidFakes = [5, 'foo', {}, true, false, null, void 0, new Date(), /.*/];
+
+    for (var i=0; i<invalidFakes.length; i++) {
+      var invalidFake = invalidFakes[i],
+          spyStrategy = new jasmineUnderTest.SpyStrategy({fn: originalFn});
+
+      expect(function() {spyStrategy.callFake(invalidFake);}).toThrowError('Argument passed to callFake should be a function, got ' + invalidFake);
+    }
+  });
+
   it("allows a return to plan stubbing after another strategy", function() {
     var originalFn = jasmine.createSpy("original"),
         fakeFn = jasmine.createSpy("fake").and.returnValue(67),
@@ -103,7 +115,7 @@ describe("SpyStrategy", function() {
 
     expect(originalFn).not.toHaveBeenCalled();
     expect(returnValue).toEqual(67);
-    
+
     spyStrategy.stub();
     returnValue = spyStrategy.exec();
 
@@ -118,7 +130,7 @@ describe("SpyStrategy", function() {
     expect(spyStrategy.callThrough()).toBe(spy);
     expect(spyStrategy.returnValue()).toBe(spy);
     expect(spyStrategy.throwError()).toBe(spy);
-    expect(spyStrategy.callFake()).toBe(spy);
+    expect(spyStrategy.callFake(function() {})).toBe(spy);
     expect(spyStrategy.stub()).toBe(spy);
   });
 });
diff --git a/src/core/SpyStrategy.js b/src/core/SpyStrategy.js
index ee343703..7e02ca91 100644
--- a/src/core/SpyStrategy.js
+++ b/src/core/SpyStrategy.js
@@ -45,6 +45,9 @@ getJasmineRequireObj().SpyStrategy = function() {
     };
 
     this.callFake = function(fn) {
+      if(!(fn instanceof Function)) {
+        throw new Error('Argument passed to callFake should be a function, got ' + fn);
+      }
       plan = fn;
       return getSpy();
     };