From c042665d9ca2ad8b6ff3a7fd01ae69ad51d2a2f6 Mon Sep 17 00:00:00 2001 From: Steve Gravrock Date: Wed, 8 Oct 2025 22:21:53 -0700 Subject: [PATCH] HtmlReporterV2 doesn't need specStarted --- lib/jasmine-core/jasmine-html.js | 2 -- spec/html/HtmlReporterV2Spec.js | 15 --------------- src/html/HtmlReporterV2.js | 2 -- 3 files changed, 19 deletions(-) diff --git a/lib/jasmine-core/jasmine-html.js b/lib/jasmine-core/jasmine-html.js index 20ffc751..5c341d38 100644 --- a/lib/jasmine-core/jasmine-html.js +++ b/lib/jasmine-core/jasmine-html.js @@ -1058,8 +1058,6 @@ jasmineRequire.HtmlReporterV2 = function(j$) { } } - specStarted() {} - specDone(result) { this.#stateBuilder.specDone(result); this.#symbols.append(result, this.#config); diff --git a/spec/html/HtmlReporterV2Spec.js b/spec/html/HtmlReporterV2Spec.js index bdec1858..05d1b4af 100644 --- a/spec/html/HtmlReporterV2Spec.js +++ b/spec/html/HtmlReporterV2Spec.js @@ -300,11 +300,6 @@ describe('HtmlReporterV2', function() { reporter.initialize(); reporter.jasmineStarted({}); reporter.suiteStarted({ id: 1 }); - reporter.specStarted({ - id: 1, - passedExpectations: [], - failedExpectations: [] - }); reporter.specDone({ id: 1, status: 'passed', @@ -361,7 +356,6 @@ describe('HtmlReporterV2', function() { passedExpectations: [{ passed: true }], duration: 1230 }; - reporter.specStarted(specResult); reporter.specDone(specResult); reporter.suiteStarted({ @@ -379,7 +373,6 @@ describe('HtmlReporterV2', function() { passedExpectations: [{ passed: true }], duration: 1240 }; - reporter.specStarted(specResult); reporter.specDone(specResult); reporter.suiteDone({ @@ -398,7 +391,6 @@ describe('HtmlReporterV2', function() { passedExpectations: [], duration: 2090 }; - reporter.specStarted(specResult); reporter.specDone(specResult); reporter.suiteDone({ @@ -863,7 +855,6 @@ describe('HtmlReporterV2', function() { }); reporter.initialize(); reporter.jasmineStarted({ totalSpecsDefined: 1 }); - reporter.specStarted(specStatus); reporter.specDone(specStatus); reporter.jasmineDone({}); }); @@ -886,7 +877,6 @@ describe('HtmlReporterV2', function() { }); reporter.initialize(); reporter.jasmineStarted({ totalSpecsDefined: 1 }); - reporter.specStarted(specStatus); reporter.specDone(specStatus); reporter.jasmineDone({}); }); @@ -914,7 +904,6 @@ describe('HtmlReporterV2', function() { } function reportWithSpecStatus(specStatus) { - reporter.specStarted(specStatus); reporter.specDone(specStatus); reporter.jasmineDone({}); } @@ -992,7 +981,6 @@ describe('HtmlReporterV2', function() { passedExpectations: [{ passed: true }], failedExpectations: [] }; - reporter.specStarted(passingSpecResult); reporter.specDone(passingSpecResult); const failingSpecResult = { @@ -1037,12 +1025,10 @@ describe('HtmlReporterV2', function() { status: 'failed', failedExpectations: [{ message: 'My After All Exception' }] }; - reporter.specStarted(failingSpecResult); reporter.specDone(failingSpecResult); reporter.suiteDone(passingSuiteResult); reporter.suiteDone(failingSuiteResult); reporter.suiteDone(passingSuiteResult); - reporter.specStarted(failingSpecResultWithDebugLogs); reporter.specDone(failingSpecResultWithDebugLogs); reporter.jasmineDone({}); }); @@ -1175,7 +1161,6 @@ describe('HtmlReporterV2', function() { ] }; - reporter.specStarted(failingSpecResult); reporter.specDone(failingSpecResult); reporter.jasmineDone({ failedExpectations: [ diff --git a/src/html/HtmlReporterV2.js b/src/html/HtmlReporterV2.js index 95801d02..111a31a0 100644 --- a/src/html/HtmlReporterV2.js +++ b/src/html/HtmlReporterV2.js @@ -85,8 +85,6 @@ jasmineRequire.HtmlReporterV2 = function(j$) { } } - specStarted() {} - specDone(result) { this.#stateBuilder.specDone(result); this.#symbols.append(result, this.#config);