Deprecate describes with no children

2020-02-12 16:44:44 -08:00
parent 18b2646d1d
commit c39c110eca
5 changed files with 36 additions and 2 deletions
@@ -141,11 +141,24 @@ describe('Env', function() {
      );

      expect(function() {
-        env.describe('fn arg', function() {});
+        env.describe('fn arg', function() {
+          env.it('has a spec', function() {});
+        });
      }).not.toThrowError(
        'describe expects a function argument; received [object Function]'
      );
    });
+
+    it('logs a deprecation when it has no children', function() {
+      spyOn(env, 'deprecated');
+      env.describe('no children', function() {});
+      expect(env.deprecated).toHaveBeenCalledWith(
+        'describe with no children' +
+          ' (describe() or it()) is deprecated and will be removed in a future ' +
+          'version of Jasmine. Please either remove the describe or add ' +
+          'children to it.'
+      );
+    });
  });

  describe('#it', function() {