From da33c7823e3aa770fad9c03333b3f140a083932f Mon Sep 17 00:00:00 2001 From: Sheel Choksi Date: Sun, 29 Sep 2013 14:42:26 -0700 Subject: [PATCH] Add missing var in front of j$ to avoid polluting global namespace Users should only have 'jasmine' in global namespace, j$ should be fully internal unless developing for jasmine As brought up by Morten Maxild --- lib/jasmine-core/jasmine.js | 2 +- src/core/requireCore.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/jasmine-core/jasmine.js b/lib/jasmine-core/jasmine.js index bfac4cb7..56c920ec 100644 --- a/lib/jasmine-core/jasmine.js +++ b/lib/jasmine-core/jasmine.js @@ -30,7 +30,7 @@ function getJasmineRequireObj() { } getJasmineRequireObj().core = function(jRequire) { - j$ = {}; + var j$ = {}; jRequire.base(j$); j$.util = jRequire.util(); diff --git a/src/core/requireCore.js b/src/core/requireCore.js index caa711eb..bdcd20c6 100644 --- a/src/core/requireCore.js +++ b/src/core/requireCore.js @@ -8,7 +8,7 @@ function getJasmineRequireObj() { } getJasmineRequireObj().core = function(jRequire) { - j$ = {}; + var j$ = {}; jRequire.base(j$); j$.util = jRequire.util();