warren/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Updated deprecaton messages for Env#throwOnExpectationFailure() and Env#stopOnSpecFailure()

Browse Source
This commit is contained in:
Steve Gravrock
2021-07-31 08:02:39 -07:00
parent b696bec9e3
commit dcaac62a6c
2 changed files with 28 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/jasmine-core/jasmine.js
+14 -6
View File
@@ -1553,18 +1553,22 @@ getJasmineRequireObj().Env = function(j$) {
* @since 2.3.0 * @since 2.3.0
* @function * @function
* @param {Boolean} value Whether to throw when a expectation fails * @param {Boolean} value Whether to throw when a expectation fails
* @deprecated Use the `oneFailurePerSpec` option with {@link Env#configure} * @deprecated Use the `stopSpecOnExpectationFailure` option with {@link Env#configure}
*/ */
this.throwOnExpectationFailure = function(value) { this.throwOnExpectationFailure = function(value) {
this.deprecated( this.deprecated(
'Setting throwOnExpectationFailure directly on Env is deprecated and will be removed in a future version of Jasmine, please use the oneFailurePerSpec option in `configure`' 'Setting throwOnExpectationFailure directly on Env is deprecated and ' +
'will be removed in a future version of Jasmine. Please use the ' +
'stopSpecOnExpectationFailure option in `configure`.'
); );
this.configure({ oneFailurePerSpec: !!value }); this.configure({ oneFailurePerSpec: !!value });
}; };
this.throwingExpectationFailures = function() { this.throwingExpectationFailures = function() {
this.deprecated( this.deprecated(
'Getting throwingExpectationFailures directly from Env is deprecated and will be removed in a future version of Jasmine, please check the oneFailurePerSpec option from `configuration`' 'Getting throwingExpectationFailures directly from Env is deprecated ' +
'and will be removed in a future version of Jasmine. Please check ' +
'the stopSpecOnExpectationFailure option from `configuration`.'
); );
return config.oneFailurePerSpec; return config.oneFailurePerSpec;
}; };
@@ -1575,18 +1579,22 @@ getJasmineRequireObj().Env = function(j$) {
* @since 2.7.0 * @since 2.7.0
* @function * @function
* @param {Boolean} value Whether to stop suite execution when a spec fails * @param {Boolean} value Whether to stop suite execution when a spec fails
* @deprecated Use the `failFast` option with {@link Env#configure} * @deprecated Use the `stopOnSpecFailure` option with {@link Env#configure}
*/ */
this.stopOnSpecFailure = function(value) { this.stopOnSpecFailure = function(value) {
this.deprecated( this.deprecated(
'Setting stopOnSpecFailure directly is deprecated and will be removed in a future version of Jasmine, please use the failFast option in `configure`' 'Setting stopOnSpecFailure directly is deprecated and will be ' +
'removed in a future version of Jasmine. Please use the ' +
'stopOnSpecFailure option in `configure`.'
); );
this.configure({ stopOnSpecFailure: !!value }); this.configure({ stopOnSpecFailure: !!value });
}; };
this.stoppingOnSpecFailure = function() { this.stoppingOnSpecFailure = function() {
this.deprecated( this.deprecated(
'Getting stoppingOnSpecFailure directly from Env is deprecated and will be removed in a future version of Jasmine, please check the failFast option from `configuration`' 'Getting stoppingOnSpecFailure directly from Env is deprecated and ' +
'will be removed in a future version of Jasmine. Please check the ' +
'stopOnSpecFailure option from `configuration`.'
); );
return config.failFast; return config.failFast;
}; };
src/core/Env.js
+14 -6
View File
@@ -543,18 +543,22 @@ getJasmineRequireObj().Env = function(j$) {
* @since 2.3.0 * @since 2.3.0
* @function * @function
* @param {Boolean} value Whether to throw when a expectation fails * @param {Boolean} value Whether to throw when a expectation fails
* @deprecated Use the `oneFailurePerSpec` option with {@link Env#configure} * @deprecated Use the `stopSpecOnExpectationFailure` option with {@link Env#configure}
*/ */
this.throwOnExpectationFailure = function(value) { this.throwOnExpectationFailure = function(value) {
this.deprecated( this.deprecated(
'Setting throwOnExpectationFailure directly on Env is deprecated and will be removed in a future version of Jasmine, please use the oneFailurePerSpec option in `configure`' 'Setting throwOnExpectationFailure directly on Env is deprecated and ' +
'will be removed in a future version of Jasmine. Please use the ' +
'stopSpecOnExpectationFailure option in `configure`.'
); );
this.configure({ oneFailurePerSpec: !!value }); this.configure({ oneFailurePerSpec: !!value });
}; };
this.throwingExpectationFailures = function() { this.throwingExpectationFailures = function() {
this.deprecated( this.deprecated(
'Getting throwingExpectationFailures directly from Env is deprecated and will be removed in a future version of Jasmine, please check the oneFailurePerSpec option from `configuration`' 'Getting throwingExpectationFailures directly from Env is deprecated ' +
'and will be removed in a future version of Jasmine. Please check ' +
'the stopSpecOnExpectationFailure option from `configuration`.'
); );
return config.oneFailurePerSpec; return config.oneFailurePerSpec;
}; };
@@ -565,18 +569,22 @@ getJasmineRequireObj().Env = function(j$) {
* @since 2.7.0 * @since 2.7.0
* @function * @function
* @param {Boolean} value Whether to stop suite execution when a spec fails * @param {Boolean} value Whether to stop suite execution when a spec fails
* @deprecated Use the `failFast` option with {@link Env#configure} * @deprecated Use the `stopOnSpecFailure` option with {@link Env#configure}
*/ */
this.stopOnSpecFailure = function(value) { this.stopOnSpecFailure = function(value) {
this.deprecated( this.deprecated(
'Setting stopOnSpecFailure directly is deprecated and will be removed in a future version of Jasmine, please use the failFast option in `configure`' 'Setting stopOnSpecFailure directly is deprecated and will be ' +
'removed in a future version of Jasmine. Please use the ' +
'stopOnSpecFailure option in `configure`.'
); );
this.configure({ stopOnSpecFailure: !!value }); this.configure({ stopOnSpecFailure: !!value });
}; };
this.stoppingOnSpecFailure = function() { this.stoppingOnSpecFailure = function() {
this.deprecated( this.deprecated(
'Getting stoppingOnSpecFailure directly from Env is deprecated and will be removed in a future version of Jasmine, please check the failFast option from `configuration`' 'Getting stoppingOnSpecFailure directly from Env is deprecated and ' +
'will be removed in a future version of Jasmine. Please check the ' +
'stopOnSpecFailure option from `configuration`.'
); );
return config.failFast; return config.failFast;
}; };