diff --git a/lib/jasmine-core/jasmine-html.js b/lib/jasmine-core/jasmine-html.js index 5ca5f625..4a5849be 100644 --- a/lib/jasmine-core/jasmine-html.js +++ b/lib/jasmine-core/jasmine-html.js @@ -109,7 +109,9 @@ jasmineRequire.HtmlReporter = function(j$) { var failure = createDom("div", {className: "spec-detail failed"}, - createDom("a", {className: "description", title: result.fullName, href: specHref(result)}, result.fullName), + createDom("div", {className: "description"}, + createDom("a", {title: result.fullName, href: specHref(result)}, result.fullName) + ), createDom("div", {className: "messages"}) ); var messages = failure.childNodes[1]; diff --git a/lib/jasmine-core/jasmine.css b/lib/jasmine-core/jasmine.css index 9a60c996..f4d35b6e 100644 --- a/lib/jasmine-core/jasmine.css +++ b/lib/jasmine-core/jasmine.css @@ -48,7 +48,8 @@ body { background-color: #eeeeee; padding: 0; margin: 5px; overflow-y: scroll; } .html-reporter .suite { margin-top: 14px; } .html-reporter .suite a { color: #333333; } .html-reporter .failures .spec-detail { margin-bottom: 28px; } -.html-reporter .failures .spec-detail .description { display: block; color: white; background-color: #b03911; } +.html-reporter .failures .spec-detail .description { background-color: #b03911; } +.html-reporter .failures .spec-detail .description a { color: white; } .html-reporter .result-message { padding-top: 14px; color: #333333; white-space: pre; } .html-reporter .result-message span.result { display: block; } .html-reporter .stack-trace { margin: 5px 0 0 0; max-height: 224px; overflow: auto; line-height: 18px; color: #666666; border: 1px solid #ddd; background: white; white-space: pre; } diff --git a/spec/javascripts/html/HtmlReporterSpec.js b/spec/javascripts/html/HtmlReporterSpec.js index ab57b038..814c0c49 100644 --- a/spec/javascripts/html/HtmlReporterSpec.js +++ b/spec/javascripts/html/HtmlReporterSpec.js @@ -461,8 +461,10 @@ describe("New HtmlReporter", function() { expect(failure.getAttribute("class")).toMatch(/failed/); expect(failure.getAttribute("class")).toMatch(/spec-detail/); - var specLink = failure.childNodes[0]; - expect(specLink.getAttribute("class")).toEqual("description"); + var specDiv = failure.childNodes[0]; + expect(specDiv.getAttribute("class")).toEqual("description"); + + var specLink = specDiv.childNodes[0]; expect(specLink.getAttribute("title")).toEqual("a suite with a failing spec"); expect(specLink.getAttribute("href")).toEqual("?spec=a%20suite%20with%20a%20failing%20spec"); diff --git a/src/html/HtmlReporter.js b/src/html/HtmlReporter.js index 71c32ee9..169f67f8 100644 --- a/src/html/HtmlReporter.js +++ b/src/html/HtmlReporter.js @@ -81,7 +81,9 @@ jasmineRequire.HtmlReporter = function(j$) { var failure = createDom("div", {className: "spec-detail failed"}, - createDom("a", {className: "description", title: result.fullName, href: specHref(result)}, result.fullName), + createDom("div", {className: "description"}, + createDom("a", {title: result.fullName, href: specHref(result)}, result.fullName) + ), createDom("div", {className: "messages"}) ); var messages = failure.childNodes[1]; diff --git a/src/html/_HTMLReporter.scss b/src/html/_HTMLReporter.scss index 3cfb3936..6b0239bb 100644 --- a/src/html/_HTMLReporter.scss +++ b/src/html/_HTMLReporter.scss @@ -288,13 +288,11 @@ body { margin-bottom: $line-height * 2; .description { - //line-height: $line-height * 2; - display: block; - - color: white; background-color: $failing-color; - //font-size: $large-font-size; + a { + color: white; + } } } } @@ -303,7 +301,7 @@ body { padding-top: $line-height; color: $text-color; - + white-space: pre; }