warren/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iscsi-command: DATA OUT PDUs must have no callback

Browse Source 
otherwise we might invoke a cmd_pdu callback multiple times
on timeout or reconnect.

Signed-off-by: Peter Lieven <pl@kamp.de>
This commit is contained in:
Peter Lieven
2016-05-02 10:08:01 +02:00
parent 2b9cd64e7c
commit 03fe4d73f7
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/iscsi-command.c
-3
View File
@@ -131,9 +131,6 @@ iscsi_send_data_out(struct iscsi_context *iscsi, struct iscsi_pdu *cmd_pdu,
/* update data segment length */ /* update data segment length */
scsi_set_uint32(&pdu->outdata.data[4], pdu->payload_len); scsi_set_uint32(&pdu->outdata.data[4], pdu->payload_len);
pdu->callback = cmd_pdu->callback;
pdu->private_data = cmd_pdu->private_data;
if (iscsi_queue_pdu(iscsi, pdu) != 0) { if (iscsi_queue_pdu(iscsi, pdu) != 0) {
iscsi_set_error(iscsi, "Out-of-memory: failed to queue iscsi " iscsi_set_error(iscsi, "Out-of-memory: failed to queue iscsi "
"scsi pdu."); "scsi pdu.");