From 053c6db9e128e5ece737867cd2e150f79433b6d5 Mon Sep 17 00:00:00 2001
From: Ser01x <sbt79@mail.ru>
Date: Wed, 21 Jul 2021 16:37:57 +0000
Subject: [PATCH] test-tool: check that ReceiveCopyResults is implemented

We check that the RECEIVE COPY STATUS(LID1) command is supported
by SCSI device before sending it.
---
 .../test_receive_copy_results_copy_status.c   | 106 +++++++++++++++++-
 1 file changed, 104 insertions(+), 2 deletions(-)

diff --git a/test-tool/test_receive_copy_results_copy_status.c b/test-tool/test_receive_copy_results_copy_status.c
index 71af29a..dbefe7e 100644
--- a/test-tool/test_receive_copy_results_copy_status.c
+++ b/test-tool/test_receive_copy_results_copy_status.c
@@ -16,6 +16,7 @@
 */
 
 #include <stdio.h>
+#include <stdbool.h>
 #include <stdlib.h>
 #include <string.h>
 #include <stdlib.h>
@@ -26,19 +27,112 @@
 #include "scsi-lowlevel.h"
 #include "iscsi-test-cu.h"
 
+
+
 void
 test_receive_copy_results_copy_status(void)
 {
-        struct scsi_task *cs_task;
+        struct scsi_task *cs_task = NULL;
         struct scsi_copy_results_copy_status *csp;
         int tgt_desc_len = 0, seg_desc_len = 0;
         int  offset = XCOPY_DESC_OFFSET, list_id = 1;
         struct iscsi_data data;
         unsigned char *xcopybuf;
+        struct scsi_inquiry_supported_pages *sup_inq;
+        struct scsi_inquiry_third_party_copy *third_party_inq;
+        struct third_party_copy_command_support *command;
+        bool third_party_page_supported = false;
+        bool receive_copy_results_supported = false;
+        int ret, i;
 
         logging(LOG_VERBOSE, LOG_BLANK_LINE);
         logging(LOG_VERBOSE, "Test RECEIVE COPY RESULTS, COPY STATUS");
 
+        logging(LOG_VERBOSE, "Get VPD pages supported list.");
+        ret = inquiry(sd, &task,
+                      1, SCSI_INQUIRY_PAGECODE_SUPPORTED_VPD_PAGES, 255,
+                      EXPECT_STATUS_GOOD);
+        CU_ASSERT_EQUAL(ret, 0);
+        if (ret != 0) {
+                logging(LOG_NORMAL, "[FAILED] Failed to get Supported VPD Pages.");
+                return;
+        }
+
+        logging(LOG_VERBOSE, "Check that RECEIVE COPY RESULTS is supported.");
+        sup_inq = scsi_datain_unmarshall(task);
+        CU_ASSERT_NOT_EQUAL(sup_inq, NULL);
+        if (sup_inq == NULL) {
+                logging(LOG_NORMAL, "[FAILED] Failed to unmarshall DATA-IN "
+                        "buffer.");
+                return;
+        }
+
+        for (i = 0; i < sup_inq->num_pages; i++) {
+                if (sup_inq->pages[i] == SCSI_INQUIRY_PAGECODE_THIRD_PARTY_COPY) {
+                        third_party_page_supported = true;
+                        break;
+                }
+        }
+        if (!third_party_page_supported) {
+                logging(LOG_NORMAL, "[SKIPPED] Third-party Copy VPD page is not "
+                        "implemented.");
+                CU_PASS("RECEIVE COPY RESULTS is not implemented.");
+                goto finished;
+        }
+        logging(LOG_VERBOSE, "Third-party Copy VPD page is supported.");
+
+        scsi_free_scsi_task(task);
+        task = NULL;
+
+        ret = inquiry(sd, &task,
+                      1, SCSI_INQUIRY_PAGECODE_THIRD_PARTY_COPY, 1024,
+                      EXPECT_STATUS_GOOD);
+        CU_ASSERT_EQUAL(ret, 0);
+        if (ret != 0) {
+                logging(LOG_NORMAL, "[FAILED] Failed to get Third-party Copy "
+                        "VPD page.");
+                return;
+        }
+
+        third_party_inq = scsi_datain_unmarshall(task);
+        CU_ASSERT_NOT_EQUAL(third_party_inq, NULL);
+        if (third_party_inq == NULL) {
+                logging(LOG_NORMAL, "[FAILED] Failed to unmarshall DATA-IN "
+                        "buffer.");
+                return;
+        }
+        CU_ASSERT_NOT_EQUAL(third_party_inq->supported_commands, NULL);
+        if (third_party_inq->supported_commands == NULL) {
+                logging(LOG_NORMAL, "[FAILED] Supported Commands descriptor is "
+                        "is not found.");
+                return;
+        }
+
+        command = third_party_inq->supported_commands->commands_supported;
+        while (command && !receive_copy_results_supported) {
+                if (command->operation_code == SCSI_OPCODE_RECEIVE_COPY_RESULTS) {
+                        for (i = 0; i < command->service_action_length; i++) {
+                                if (command->service_action[i] ==
+                                            SCSI_COPY_RESULTS_COPY_STATUS) {
+                                        receive_copy_results_supported = true;
+                                        break;
+                                }
+                        }
+                }
+
+                command = command->next;
+        }
+        if (!receive_copy_results_supported) {
+                logging(LOG_NORMAL, "[SKIPPED] RECEIVE COPY RESULTS is not "
+                        "implemented.");
+                CU_PASS("RECEIVE COPY RESULTS is not implemented.");
+                goto finished;
+        }
+        logging(LOG_VERBOSE, "RECEIVE COPY RESULTS is supported.");
+
+        scsi_free_scsi_task(task);
+        task = NULL;
+
         logging(LOG_VERBOSE, "No copy in progress");
         RECEIVE_COPY_RESULTS(&cs_task, sd, SCSI_COPY_RESULTS_COPY_STATUS,
                              list_id, NULL, EXPECT_INVALID_FIELD_IN_CDB);
@@ -76,5 +170,13 @@ test_receive_copy_results_copy_status(void)
         RECEIVE_COPY_RESULTS(&cs_task, sd, SCSI_COPY_RESULTS_COPY_STATUS,
                              list_id, (void **)&csp, EXPECT_STATUS_GOOD);
 
-        scsi_free_scsi_task(cs_task);
+finished:
+        if (task != NULL) {
+                scsi_free_scsi_task(task);
+                task = NULL;
+        }
+        if (cs_task != NULL) {
+                scsi_free_scsi_task(cs_task);
+                cs_task = NULL;
+        }
 }