warren/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test_read6_simple: Avoid triggering a use-after-free

Browse Source 
Do not use the 'task' pointer after the memory it points at has been freed.
Detected via valgrind.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
This commit is contained in:
Bart Van Assche
2013-09-29 21:05:37 +02:00
committed by Ronnie Sahlberg
parent 4653cd8df4
commit 1337185fe9
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test-tool/test_read6_simple.c
-1
View File
@@ -70,7 +70,6 @@ test_read6_simple(void)
if (task->status != SCSI_STATUS_GOOD) { if (task->status != SCSI_STATUS_GOOD) {
logging(LOG_NORMAL, "[FAILED] READ6 command: " logging(LOG_NORMAL, "[FAILED] READ6 command: "
"failed with sense. %s", iscsi_get_error(iscsic)); "failed with sense. %s", iscsi_get_error(iscsic));
scsi_free_scsi_task(task);
} }
CU_ASSERT_EQUAL(task->status, SCSI_STATUS_GOOD); CU_ASSERT_EQUAL(task->status, SCSI_STATUS_GOOD);