warren/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: fix ExtendedCopy.Large SKIPPED cases

Browse Source 
CU_PASS() needs to be coupled with a return to actually skip the test.
Similarly, the CU_PASS message isn't printed, so a logging() call is
also needed here.

Signed-off-by: David Disseldorp <ddiss@suse.de>
This commit is contained in:
David Disseldorp
2021-07-29 17:39:39 +02:00
parent 3c977c573a
commit 73d541b00b
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test-tool/test_extendedcopy_simple.c
View File

@@ -134,13 +134,19 @@ test_extendedcopy_large(void)
scsi_free_scsi_task(edl_task);
if (cp_len_bytes == 0) {
logging(LOG_NORMAL,
"[SKIPPED] BLK_TO_BLK_OFF_SEG_DESCR not supported");
CU_PASS("[SKIPPED] BLK_TO_BLK_OFF_SEG_DESCR not supported");
return;
}
if (cp_len_bytes > TEST_XCOPY_LARGE_CP_LEN_MAX) {
cp_len_bytes = TEST_XCOPY_LARGE_CP_LEN_MAX;
}
if (num_blocks < (cp_len_bytes / block_size) * 2) {
logging(LOG_NORMAL,
"[SKIPPED] device too small to handle maxlen XCOPY");
CU_PASS("[SKIPPED] device too small to handle maxlen XCOPY");
return;
}
write_blocks = num_blocks / 2;