From 957cc9623223dcbf9dcf7ee27455dabfb7bd29eb Mon Sep 17 00:00:00 2001 From: David Disseldorp Date: Thu, 15 Oct 2020 01:03:10 +0200 Subject: [PATCH] test-tool: add COMPARE AND WRITE MiscompareSense test This test checks regular sense/ascq values on miscompare as well as the Information sense field, which should be set as follows: sense key set to MISCOMPARE and the additional sense code set to MISCOMPARE DURING VERIFY OPERATION. In the sense data (see 4.18 and SPC-5) the offset from the start of the Data-Out Buffer to the first byte of data that was not equal shall be reported in the INFORMATION field. Signed-off-by: David Disseldorp --- test-tool/iscsi-test-cu.c | 1 + test-tool/iscsi-test-cu.h | 1 + test-tool/test_compareandwrite_miscompare.c | 76 +++++++++++++++++++++ 3 files changed, 78 insertions(+) diff --git a/test-tool/iscsi-test-cu.c b/test-tool/iscsi-test-cu.c index 76a41d5..b0c4fc1 100644 --- a/test-tool/iscsi-test-cu.c +++ b/test-tool/iscsi-test-cu.c @@ -68,6 +68,7 @@ static CU_TestInfo tests_compareandwrite[] = { { "Simple", test_compareandwrite_simple }, { "DpoFua", test_compareandwrite_dpofua }, { "Miscompare", test_compareandwrite_miscompare }, + { "MiscompareSense", test_compareandwrite_miscompare_sense }, { "Unwritten", test_compareandwrite_unwritten }, { "InvalidDataOutSize", test_compareandwrite_invalid_dataout_size }, diff --git a/test-tool/iscsi-test-cu.h b/test-tool/iscsi-test-cu.h index af5cced..49b7819 100644 --- a/test-tool/iscsi-test-cu.h +++ b/test-tool/iscsi-test-cu.h @@ -54,6 +54,7 @@ void test_teardown(void); void test_compareandwrite_simple(void); void test_compareandwrite_dpofua(void); void test_compareandwrite_miscompare(void); +void test_compareandwrite_miscompare_sense(void); void test_compareandwrite_unwritten(void); void test_compareandwrite_invalid_dataout_size(void); diff --git a/test-tool/test_compareandwrite_miscompare.c b/test-tool/test_compareandwrite_miscompare.c index 3fb6374..04a9fb5 100644 --- a/test-tool/test_compareandwrite_miscompare.c +++ b/test-tool/test_compareandwrite_miscompare.c @@ -158,3 +158,79 @@ test_compareandwrite_miscompare(void) } } } + +void +test_compareandwrite_miscompare_sense(void) +{ + unsigned i; + + CHECK_FOR_DATALOSS; + CHECK_FOR_SBC; + CHECK_FOR_ISCSI(sd); + + if (inq_bl->max_cmp < 1) { + logging(LOG_NORMAL, "[SKIPPED] COMPAREANDWRITE " + "max_cmp less than 1."); + CU_PASS("[SKIPPED] single block COMPAREANDWRITE not supported " + "Skipping test"); + return; + } + + logging(LOG_VERBOSE, LOG_BLANK_LINE); + logging(LOG_VERBOSE, "Test COMPARE_AND_WRITE of 1 block at the " + "start of the LUN"); + + logging(LOG_VERBOSE, "Write 1 block of 'A' at LBA:0"); + memset(scratch, 'A', 2 * block_size); + + WRITE16(sd, 0, block_size, + block_size, 0, 0, 0, 0, 0, scratch, + EXPECT_STATUS_GOOD); + + memset(scratch + block_size, 'B', block_size); + + logging(LOG_VERBOSE, "Overwrite blocks with 'B' " + "at LBA:0 (if they all contain 'A')"); + COMPAREANDWRITE(sd, 0, + scratch, 2 * block_size, block_size, + 0, 0, 0, 0, + EXPECT_STATUS_GOOD); + /* we've confirmed that c&w is supported, time for the proper test... */ + + logging(LOG_VERBOSE, "Vary location of miscompare in %zd bytes and check" + "sense", block_size); + memset(scratch + block_size, 'C', block_size); + + for (i = 0; i < block_size; i++) { + struct scsi_task *tsk; + struct scsi_iovec iov; + + logging(LOG_VERBOSE, "Fill buffer with 'B' except for %d " + "offset", i); + memset(scratch, 'B', block_size); + scratch[i] = 'Z'; + + tsk = scsi_cdb_compareandwrite(0, 2 * block_size, block_size, + 0, 0, 0, 0, 0); + CU_ASSERT(tsk != NULL); + + iov.iov_base = scratch; + iov.iov_len = 2 * block_size; + scsi_task_set_iov_out(tsk, &iov, 1); + + tsk = iscsi_scsi_command_sync(sd->iscsi_ctx, sd->iscsi_lun, + tsk, NULL); + CU_ASSERT_FATAL(tsk != NULL); + CU_ASSERT(tsk->status == SCSI_STATUS_CHECK_CONDITION); + CU_ASSERT(tsk->sense.key == SCSI_SENSE_MISCOMPARE); + CU_ASSERT(tsk->sense.ascq + == SCSI_SENSE_ASCQ_MISCOMPARE_DURING_VERIFY); + if (tsk->sense.info_valid) { + logging(LOG_VERBOSE, "Check Information field provided" + " with miscompare sense response"); + CU_ASSERT_EQUAL(tsk->sense.information, i); + } + + scsi_free_scsi_task(tsk); + } +}