From e7c44b802f521e600e8e9a38479046f60570820e Mon Sep 17 00:00:00 2001 From: Anatoliy Glagolev Date: Fri, 27 Jun 2025 17:21:44 -0600 Subject: [PATCH] iscsi-inq: binary values in hex While printing device identification information format binary values as hex instead of ASCII characters. --- utils/iscsi-inq.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/utils/iscsi-inq.c b/utils/iscsi-inq.c index beb8510..114fefe 100644 --- a/utils/iscsi-inq.c +++ b/utils/iscsi-inq.c @@ -87,7 +87,16 @@ void inquiry_device_identification(struct scsi_inquiry_device_identification *in printf("PIV:%d\n", dev->piv); printf("Association:(%d) %s\n", dev->association, scsi_association_to_str(dev->association)); printf("Designator Type:(%d) %s\n", dev->designator_type, scsi_designator_type_to_str(dev->designator_type)); - printf("Designator:[%s]\n", dev->designator); + if (dev->code_set == SCSI_CODESET_BINARY) { + int j; + printf("Designator:["); + for (j = 0; j < dev->designator_length; ++j) { + printf(" %02x", (unsigned char)dev->designator[j]); + } + printf("]\n"); + } else { + printf("Designator:[%s]\n", dev->designator); + } } }