warren/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tests: remove the warning if a SSD supports SANITIZE/OVERWRITE

Browse Source 
There is technically no reason why a SSD with (assumingly with thin
provisioning) can not support SANITIZE/OVERWRITE instead or or in addition
to the more expected SANITIZE/BLOCK-ERASE so remove the warning for this.

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
This commit is contained in:
Ronnie Sahlberg
2016-05-01 12:35:29 -07:00
parent 526039793e
commit a6fc65b4ef
3 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/scsi-lowlevel.h
+2
View File
@@ -563,6 +563,8 @@ struct scsi_inquiry_block_limits {
uint32_t max_atomic_xfer_len; uint32_t max_atomic_xfer_len;
uint32_t atomic_align; uint32_t atomic_align;
uint32_t atomic_gran; uint32_t atomic_gran;
uint32_t max_atomic_tl_with_atomic_boundary;
uint32_t max_atomic_boundary_size;
}; };
struct scsi_inquiry_block_device_characteristics { struct scsi_inquiry_block_device_characteristics {
lib/scsi-lowlevel.c
+4
View File
@@ -1428,6 +1428,10 @@ scsi_inquiry_unmarshall_block_limits(struct scsi_task *task)
inq->max_atomic_xfer_len = task_get_uint32(task, 44); inq->max_atomic_xfer_len = task_get_uint32(task, 44);
inq->atomic_align = task_get_uint32(task, 48); inq->atomic_align = task_get_uint32(task, 48);
inq->atomic_gran = task_get_uint32(task, 52); inq->atomic_gran = task_get_uint32(task, 52);
inq->max_atomic_tl_with_atomic_boundary =
task_get_uint32(task, 56);
inq->max_atomic_boundary_size =
task_get_uint32(task, 60);
return inq; return inq;
} }
test-tool/test_sanitize_overwrite.c
-4
View File
@@ -86,10 +86,6 @@ test_sanitize_overwrite(void)
"or a SSD device."); "or a SSD device.");
if (inq_bdc && inq_bdc->medium_rotation_rate == 0) { if (inq_bdc && inq_bdc->medium_rotation_rate == 0) {
logging(LOG_NORMAL, "This is a HDD device"); logging(LOG_NORMAL, "This is a HDD device");
logging(LOG_NORMAL, "[WARNING] SANITIZE OVERWRITE opcode is "
"supported but MediumRotationRate is 0 "
"indicating that this is an SSD. Only HDDs should "
"implement OVERWRITE");
} else { } else {
logging(LOG_NORMAL, "This is a SSD device"); logging(LOG_NORMAL, "This is a SSD device");
} }