From c437afa825e281fc892ca9f0e9b8e98bd6ce8579 Mon Sep 17 00:00:00 2001
From: orbea <orbea@riseup.net>
Date: Sat, 22 May 2021 18:55:06 -0700
Subject: [PATCH] build: Add -no-undefined where missing

Signed-off-by: orbea <orbea@riseup.net>
---
 examples/Makefile.am  | 1 +
 lib/Makefile.am       | 2 ++
 test-tool/Makefile.am | 1 +
 tests/Makefile.am     | 1 +
 utils/Makefile.am     | 1 +
 5 files changed, 6 insertions(+)

diff --git a/examples/Makefile.am b/examples/Makefile.am
index 00fd8d0..4807178 100644
--- a/examples/Makefile.am
+++ b/examples/Makefile.am
@@ -1,6 +1,7 @@
 AM_CPPFLAGS=-I. -I${srcdir}/../include "-D_U_=__attribute__((unused))" \
 	"-D_R_(A,B)=__attribute__((format(printf,A,B)))"
 AM_CFLAGS=$(WARN_CFLAGS)
+AM_LDFLAGS=-no-undefined
 LIBS=../lib/libiscsi.la
 
 noinst_PROGRAMS = iscsiclient iscsi-dd
diff --git a/lib/Makefile.am b/lib/Makefile.am
index 6067e83..e6f82c8 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -20,6 +20,8 @@ if HAVE_LINUX_ISER
 libiscsipriv_la_LIBADD = -libverbs -lrdmacm -lpthread
 endif
 
+libiscsipriv_la_LDFLAGS = -no-undefined
+
 libiscsipriv_la_CPPFLAGS = -I${srcdir}/../include -I$(srcdir)/include \
 	"-D_U_=__attribute__((unused))" \
 	"-D_R_(A,B)=__attribute__((format(printf,A,B)))"
diff --git a/test-tool/Makefile.am b/test-tool/Makefile.am
index a27daa3..f40787a 100644
--- a/test-tool/Makefile.am
+++ b/test-tool/Makefile.am
@@ -2,6 +2,7 @@ AM_CPPFLAGS=-I. -I${srcdir}/../include \
 	"-D_U_=__attribute__((unused)) " \
 	"-D_R_(A,B)=__attribute__((format(printf,A,B)))"
 AM_CFLAGS=$(WARN_CFLAGS)
+AM_LDFLAGS=-no-undefined
 LIBS = ../lib/libiscsipriv.la
 
 EXTRA_DIST = README
diff --git a/tests/Makefile.am b/tests/Makefile.am
index f50dfa4..06bf504 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -1,6 +1,7 @@
 AM_CPPFLAGS = -I${srcdir}/../include "-D_U_=__attribute__((unused))" \
 	"-D_R_(A,B)=__attribute__((format(printf,A,B)))"
 AM_CFLAGS = $(WARN_CFLAGS)
+AM_LDFLAGS = -no-undefined
 LIBS = ../lib/libiscsi.la
 
 noinst_PROGRAMS = prog_reconnect prog_reconnect_timeout prog_noop_reply \
diff --git a/utils/Makefile.am b/utils/Makefile.am
index 8dfaca7..7aab327 100644
--- a/utils/Makefile.am
+++ b/utils/Makefile.am
@@ -1,6 +1,7 @@
 AM_CPPFLAGS = -I${srcdir}/../include "-D_U_=__attribute__((unused))" \
 	"-D_R_(A,B)=__attribute__((format(printf,A,B)))"
 AM_CFLAGS = $(WARN_CFLAGS)
+AM_LDFLAGS = -no-undefined
 LIBS = ../lib/libiscsi.la
 
 bin_PROGRAMS = iscsi-inq iscsi-ls iscsi-perf iscsi-readcapacity16 \