warren/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix data segment length comparison to unsigned long

Browse Source 
In logic.c, data segment parameters in the text segment are converted to
signed longs.  Changing from strtol -> strtoul fixes compiler errors on
certain platforms that warn against comparing a signed long with
uint32_t using MIN.
This commit is contained in:
Paul Carlisle
2020-01-27 16:56:59 -08:00
parent 72f2816ea5
commit f2d750260a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/login.c
+2 -2
View File
@@ -1242,11 +1242,11 @@ iscsi_process_login_reply(struct iscsi_context *iscsi, struct iscsi_pdu *pdu,
/* iSER specific keys */ /* iSER specific keys */
if (!strncmp(ptr, "InitiatorRecvDataSegmentLength=", 31)) { if (!strncmp(ptr, "InitiatorRecvDataSegmentLength=", 31)) {
iscsi->initiator_max_recv_data_segment_length = MIN(strtol(ptr + 31, NULL, 10), iscsi->initiator_max_recv_data_segment_length = MIN(strtoul(ptr + 31, NULL, 10),
iscsi->initiator_max_recv_data_segment_length); iscsi->initiator_max_recv_data_segment_length);
} }
if (!strncmp(ptr, "TargetRecvDataSegmentLength=", 28)) { if (!strncmp(ptr, "TargetRecvDataSegmentLength=", 28)) {
iscsi->target_max_recv_data_segment_length = MIN(strtol(ptr + 28, NULL, 10), iscsi->target_max_recv_data_segment_length = MIN(strtoul(ptr + 28, NULL, 10),
iscsi->target_max_recv_data_segment_length); iscsi->target_max_recv_data_segment_length);
} }