4a973e9a4e
SCSI: Pass the expected opcode to scsi_cdb_unmarshall()
...
Pass the opcode we expect to the unmarshalling function so it can do a basic
check that we are trying to unmarshalling the right kind of cdb.
2012-11-20 19:16:42 -08:00
890471c8cc
Add support to unmarshall a CDB into a structure and update iscsi-dd
...
Add two new helper functions scsi_get_uint32() and scsi_get_uint16()
2012-11-20 19:00:55 -08:00
b4746678f9
Merge pull request #38 from aredlich/master
...
Remove scsi_task->params
2012-11-19 18:19:28 -08:00
5194d13e73
scsi-lowlevel: remove scsi_maintenancein_params and finally scsi_task->params too
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 23:28:32 +01:00
8baa843d73
scsi-lowlevel: remove scsi_readtoc_params and fix READ TOC format field
...
Set the format field in the READ TOC CDB (lower nibble of byte 2).
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 23:16:45 +01:00
551298adfb
scsi-lowlevel: remove scsi_serviceactionin_params and plug potential memleaks
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 22:57:59 +01:00
fa158865d2
scsi-lowlevel: remove scsi_modesense6_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 22:47:14 +01:00
5f414317dc
scsi-lowlevel: remove scsi_inquiry_params and refactor INQUIRY data-in unmarshalling
...
Split the INQUIRY data-in unmarshalling into smaller chunks, fixing some
potential memory leaks along the way.
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 22:46:04 +01:00
b5a9ba6159
scsi-lowlevel: remove scsi_readcapacity10_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 22:04:57 +01:00
188505a72d
scsi-lowlevel: remove scsi_verify16_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:59:42 +01:00
de67d86e64
scsi-lowlevel: remove scsi_verify12_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:58:30 +01:00
10fd2f560b
scsi-lowlevel: remove scsi_verify10_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:57:00 +01:00
1dbdd04795
scsi-lowlevel: remove scsi_writeverify16_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:55:01 +01:00
a262d07c4b
scsi-lowlevel: remove scsi_writeverify12_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:53:44 +01:00
fff2527cda
scsi-lowlevel: remove scsi_writeverify10_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:52:34 +01:00
8169c3e280
scsi-lowlevel: remove scsi_compareandwrite_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:51:10 +01:00
9f7f7f1e0d
scsi-lowlevel: remove scsi_orwrite_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:48:17 +01:00
8f513c23f5
scsi-lowlevel: remove scsi_preventallow_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:46:52 +01:00
a02cd53cfc
scsi-lowlevel: remove scsi_startstopunit_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:45:02 +01:00
3ec1a2147f
scsi-lowlevel: remove scsi_write16_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:43:15 +01:00
f95d86f762
scsi-lowlevel: remove scsi_write12_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:41:53 +01:00
1ca5f447fc
scsi-lowlevel: remove scsi_write10_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:40:27 +01:00
daed6117c8
scsi-lowlevel: remove scsi_read16_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:38:35 +01:00
17eff2d8d9
scsi-lowlevel: remove scsi_read12_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:37:05 +01:00
f955449ecc
scsi-lowlevel: remove scsi_read10_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:35:37 +01:00
d95e811ccf
scsi-lowlevel: remove scsi_read6_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:34:08 +01:00
76aa2693c4
scsi-lowlevel: remove scsi_reportluns_params
...
Signed-off-by: Arne Redlich <arne.redlich@googlemail.com >
2012-11-18 21:31:11 +01:00
f9767e729a
VERIFY10/12/16 If BYTCHK is false we dont need to transfer any blocks to the target
...
If BYTCHK is false the target will perform a medium check of the indicated
LBAs only and not compare with anything out of the DATA-OUT buffers.
As such we dont need to/should not transfer any DAT-OUT to the target.
2012-11-18 09:46:51 -08:00
a5b8224f4e
Dont include iscsi headers from the scsi implementation in scsi-lowlevel.c
2012-11-11 09:49:49 -08:00
3b05e9996f
Move cancel_task and cancel_all_tasks from scsi-lowlevel.c to scsi-command.c
...
These two functions belong in the iscsi layer, not the scsi layer so move them
out from scsi-lowlevel.c so that we can start turning scsi-lowlevel.c to a pure
scsi layer and remove all dependencies to iscsi from it.
2012-11-11 09:44:11 -08:00
49af416f47
When we cancel a scsi task we don't need to unlink the in_buffers
...
We dont need to unlink the in-buffers when cancelling a scsi task
since the whole task structure will go away shortly anyway and all
entries in the link will be automatically freed when the task is freed.
2012-11-11 09:35:34 -08:00
4de36794f2
Make scsi_allocated_memory private to scsi-lowlevel and remove the ptr pointer
...
Change the list-head structure for in-task scsi memory allocations to
be private to scsi-lowlevel since is is never accessed from anyehwere else and
it is private to this function.
Remove the pointer to the user data in the list head and replace it with a zero length buffer at the end of the header.
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com >
2012-11-11 08:07:26 -08:00
a0b9080c6c
SCSI half mallocs in scsi_malloc
2012-11-11 08:07:13 -08:00
8fbc536779
TYPO: 'calculate' in comments
2012-10-25 12:59:55 -05:00
b81bdd3932
Merge with upstream
2012-10-25 12:56:26 -05:00
1eaca70a52
Add MaintenanceIn: Report Supported Opcodes (all) and testcase.
2012-10-25 12:48:37 -05:00
20cf2b279e
Fix incorrect whitespaces
...
At a few places there where spaces where tabulators where appropriate
2012-10-20 19:08:57 +02:00
c3adf1d814
Merge pull request #20 from jongrimm/master
...
RESERVE6/RELEASE6 Commands + testcase.
2012-09-27 18:39:22 -07:00
c7d8d2593c
Add RESERVE6/RELEASE6 Support.
2012-09-27 12:45:06 -05:00
85e427ea54
SCSI: READTOC change alloclen to a uint32 and encode it in the CDB
2012-09-25 06:54:01 -07:00
c3c1628c1d
read TOC: set XFER_NONE when xferlen==0 to match Ronnie's change
2012-09-24 10:43:07 -05:00
d6bea3db52
merge fixup
2012-09-24 10:22:58 -05:00
e55ec72f36
Add Read TOC (0x43) Command Support (and basic testcase).
2012-09-24 10:15:00 -05:00
62b8681409
SCSI: Fix all remaining places where alloc_len==0 means xfer direction should be == NONE
2012-09-19 19:43:01 -07:00
8f98cf3e12
INQUIRY: When alloc_len is set to 0 we should set XFER direction to NONOE, not READ
2012-09-19 18:23:54 -07:00
ead085ecd0
SCSI: INQUIRY fullsize is additional-length + 5, not +3
...
This bug would report the standard inquiry data size two bytes less than expected
2012-09-12 07:07:04 -07:00
dd006029a2
SCSI: Add unmarshalling of inquiry ADITIONAL_LENGTH field
2012-09-12 06:57:41 -07:00
116af01156
TYPO: Change periperal_device_type to just device_type
...
but leave the old name as a define for backward compatibility
2012-09-03 09:45:59 -07:00
2a15e39460
Add a new sense code
2012-07-30 07:38:38 +10:00
43bf059fca
Add ASCQ for MEDIUM_REMOVAL_PREVENTED
2012-07-21 10:28:32 +10:00
Ronnie Sahlberg