cacc144a29
This patch avoids that Valgrind reports that an uninitialized buffer is passed to writev(): Syscall param writev(vector[...]) points to uninitialised byte(s) at 0x5557D07: writev (in /lib64/libc-2.19.so) by 0x5269BFD: iscsi_iovector_readv_writev (socket.c:509) by 0x526A7A9: iscsi_write_to_socket (socket.c:727) by 0x526AE47: iscsi_service (socket.c:888) by 0x526B632: event_loop (sync.c:67) by 0x526D925: iscsi_scsi_command_sync (sync.c:1223) by 0x405970: send_scsi_command (iscsi-support.c:276) by 0x40B190: extendedcopy (iscsi-support.c:2673) by 0x40E9FE: test_extendedcopy_param (test_extendedcopy_param.c:63) by 0x503E260: ??? (in /usr/lib64/libcunit.so.1.0.1) by 0x503E56E: ??? (in /usr/lib64/libcunit.so.1.0.1) by 0x503E8A5: CU_run_all_tests (in /usr/lib64/libcunit.so.1.0.1) Address 0xffefff864 is on thread 1's stack in frame #8, created by test_extendedcopy_param (test_extendedcopy_param.c:31) Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
83 lines
2.2 KiB
C
83 lines
2.2 KiB
C
/*
|
|
Copyright (C) 2015 Ronnie Sahlberg <ronniesahlberg@gmail.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 2 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
|
|
#include <CUnit/CUnit.h>
|
|
|
|
#include "iscsi.h"
|
|
#include "scsi-lowlevel.h"
|
|
#include "iscsi-support.h"
|
|
#include "iscsi-test-cu.h"
|
|
|
|
|
|
void
|
|
test_writeatomic16_simple(void)
|
|
{
|
|
int i, gran, ret;
|
|
const size_t bufsz = 256 * block_size;
|
|
unsigned char *buf = alloca(bufsz);
|
|
|
|
|
|
CHECK_FOR_DATALOSS;
|
|
CHECK_FOR_SBC;
|
|
|
|
if (!inq_bl) {
|
|
CU_PASS("BlockLimits VPD is not available. Skipping test.\n");
|
|
return;
|
|
}
|
|
|
|
logging(LOG_VERBOSE, LOG_BLANK_LINE);
|
|
|
|
memset(buf, 0, bufsz);
|
|
gran = inq_bl->atomic_gran ? inq_bl->atomic_gran : 1;
|
|
ret = writeatomic16(sd, 0,
|
|
block_size * gran,
|
|
block_size, 0, 0, 0, 0, buf,
|
|
EXPECT_STATUS_GOOD);
|
|
if (ret == -2) {
|
|
logging(LOG_NORMAL, "[SKIPPED] WRITEATOMIC16 is not implemented.");
|
|
CU_PASS("WRITEATOMIC16 is not implemented.");
|
|
return;
|
|
}
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
|
|
logging(LOG_VERBOSE, "Test WRITEATOMIC16 of 1-256 blocks at the start of the LUN");
|
|
memset(buf, 0xa6, 256 * block_size);
|
|
for (i = gran; i <= 256; i += gran) {
|
|
if (maximum_transfer_length && maximum_transfer_length < i) {
|
|
break;
|
|
}
|
|
ret = writeatomic16(sd, 0, i * block_size,
|
|
block_size, 0, 0, 0, 0, buf,
|
|
EXPECT_STATUS_GOOD);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
}
|
|
|
|
logging(LOG_VERBOSE, "Test WRITEATOMIC16 of 1-256 blocks at the end of the LUN");
|
|
for (i = gran; i <= 256; i += gran) {
|
|
if (maximum_transfer_length && maximum_transfer_length < i) {
|
|
break;
|
|
}
|
|
ret = writeatomic16(sd, num_blocks - i,
|
|
i * block_size, block_size, 0, 0, 0, 0, buf,
|
|
EXPECT_STATUS_GOOD);
|
|
CU_ASSERT_EQUAL(ret, 0);
|
|
}
|
|
}
|