Parallel: fail if randomization is disabled or a seed is specified

This commit is contained in:
Steve Gravrock
2022-10-12 20:08:42 -07:00
parent bb497beeff
commit 47c64a86d5
3 changed files with 48 additions and 0 deletions

View File

@@ -1674,6 +1674,11 @@ getJasmineRequireObj().Env = function(j$) {
*/
this.execute = async function(runablesToRun) {
installGlobalErrors();
if (parallelLoadingState) {
validateConfigForParallel();
}
return runner.execute(runablesToRun);
};
@@ -1831,6 +1836,16 @@ getJasmineRequireObj().Env = function(j$) {
}
}
function validateConfigForParallel() {
if (!config.random) {
throw new Error('Randomization cannot be disabled in parallel mode');
}
if (config.seed !== null && config.seed !== undefined) {
throw new Error('Random seed cannot be set in parallel mode');
}
}
this.describe = function(description, definitionFn) {
ensureIsNotNested('describe');
return suiteBuilder.describe(description, definitionFn).metadata;

View File

@@ -752,6 +752,24 @@ describe('Env', function() {
await env.execute();
expect(jasmineUnderTest.Suite.prototype.reset).not.toHaveBeenCalled();
});
describe('In parallel mode', function() {
it('rejects if random is set to false', async function() {
env.setParallelLoadingState('specs');
env.configure({ random: false });
await expectAsync(env.execute()).toBeRejectedWithError(
'Randomization cannot be disabled in parallel mode'
);
});
it('rejects if seed is set', async function() {
env.setParallelLoadingState('specs');
env.configure({ seed: 1234 });
await expectAsync(env.execute()).toBeRejectedWithError(
'Random seed cannot be set in parallel mode'
);
});
});
});
describe('#spyOnGlobalErrorsAsync', function() {

View File

@@ -532,6 +532,11 @@ getJasmineRequireObj().Env = function(j$) {
*/
this.execute = async function(runablesToRun) {
installGlobalErrors();
if (parallelLoadingState) {
validateConfigForParallel();
}
return runner.execute(runablesToRun);
};
@@ -689,6 +694,16 @@ getJasmineRequireObj().Env = function(j$) {
}
}
function validateConfigForParallel() {
if (!config.random) {
throw new Error('Randomization cannot be disabled in parallel mode');
}
if (config.seed !== null && config.seed !== undefined) {
throw new Error('Random seed cannot be set in parallel mode');
}
}
this.describe = function(description, definitionFn) {
ensureIsNotNested('describe');
return suiteBuilder.describe(description, definitionFn).metadata;