warren/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions 9 Packages Projects Releases Wiki Activity

Added a migration guide link to multiple done call deprecations

Browse Source
This commit is contained in:
Steve Gravrock
2021-12-14 08:16:06 -08:00
parent f3b26a0688
commit 57c294b307
7 changed files with 47 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/jasmine-core/jasmine.js
View File

@@ -933,7 +933,9 @@ x */
"An asynchronous function called its 'done' " +
'callback more than once. This is a bug in the spec, beforeAll, ' +
'beforeEach, afterAll, or afterEach function in question. This will ' +
'be treated as an error in a future version.\n' +
'be treated as an error in a future version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.\n' +
'(in spec: ' +
self.getFullName() +
')',
@@ -8780,7 +8782,10 @@ getJasmineRequireObj().ReportDispatcher = function(j$) {
deprecated(
"An asynchronous reporter callback called its 'done' callback " +
'more than once. This is a bug in the reporter callback in ' +
'question. This will be treated as an error in a future version.',
'question. This will be treated as an error in a future ' +
'version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.',
{ ignoreRunnable: true }
);
}
@@ -10370,7 +10375,9 @@ getJasmineRequireObj().Suite = function(j$) {
"An asynchronous function called its 'done' callback more than " +
'once. This is a bug in the spec, beforeAll, beforeEach, afterAll, ' +
'or afterEach function in question. This will be treated as an error ' +
'in a future version.\n' +
'in a future version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.\n' +
'(in suite: ' +
this.getFullName() +
')';
@@ -10379,7 +10386,9 @@ getJasmineRequireObj().Suite = function(j$) {
'A top-level beforeAll or afterAll function called its ' +
"'done' callback more than once. This is a bug in the beforeAll " +
'or afterAll function in question. This will be treated as an ' +
'error in a future version.';
'error in a future version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.';
}
this.env.deprecated(msg, { ignoreRunnable: true });

4
spec/core/SpecSpec.js
View File

@@ -538,7 +538,9 @@ describe('Spec', function() {
"An asynchronous function called its 'done' " +
'callback more than once. This is a bug in the spec, beforeAll, ' +
'beforeEach, afterAll, or afterEach function in question. This will ' +
'be treated as an error in a future version.\n' +
'be treated as an error in a future version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.\n' +
'(in spec: a spec)',
{ ignoreRunnable: true }
);

8
spec/core/SuiteSpec.js
View File

@@ -236,7 +236,9 @@ describe('Suite', function() {
'A top-level beforeAll or afterAll function called its ' +
"'done' callback more than once. This is a bug in the beforeAll " +
'or afterAll function in question. This will be treated as an ' +
'error in a future version.',
'error in a future version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.',
{ ignoreRunnable: true }
);
});
@@ -258,7 +260,9 @@ describe('Suite', function() {
"An asynchronous function called its 'done' callback more than " +
'once. This is a bug in the spec, beforeAll, beforeEach, afterAll, ' +
'or afterEach function in question. This will be treated as an error ' +
'in a future version.\n' +
'in a future version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.\n' +
'(in suite: the parent suite the suite)',
{ ignoreRunnable: true }
);

16
spec/core/integration/EnvSpec.js
View File

@@ -519,7 +519,9 @@ describe('Env integration', function() {
'A top-level beforeAll or afterAll function called its ' +
"'done' callback more than once. This is a bug in the beforeAll " +
'or afterAll function in question. This will be treated as an ' +
'error in a future version.';
'error in a future version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.';
spyOn(console, 'error');
env.addReporter(reporter);
@@ -555,7 +557,9 @@ describe('Env integration', function() {
"An asynchronous function called its 'done' " +
'callback more than once. This is a bug in the spec, beforeAll, ' +
'beforeEach, afterAll, or afterEach function in question. This will ' +
'be treated as an error in a future version.';
'be treated as an error in a future version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.';
spyOn(console, 'error');
env.addReporter(reporter);
@@ -601,7 +605,9 @@ describe('Env integration', function() {
"An asynchronous function called its 'done' " +
'callback more than once. This is a bug in the spec, beforeAll, ' +
'beforeEach, afterAll, or afterEach function in question. This will ' +
'be treated as an error in a future version.\n' +
'be treated as an error in a future version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.\n' +
'(in spec: a suite a spec)';
spyOn(console, 'error');
@@ -644,7 +650,9 @@ describe('Env integration', function() {
var message =
"An asynchronous reporter callback called its 'done' callback more " +
'than once. This is a bug in the reporter callback in question. This ' +
'will be treated as an error in a future version.\nNote: This message ' +
'will be treated as an error in a future version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.\nNote: This message ' +
'will be shown only once. Set the verboseDeprecations config property ' +
'to true to see every occurrence.';

5
src/core/ReportDispatcher.js
View File

@@ -48,7 +48,10 @@ getJasmineRequireObj().ReportDispatcher = function(j$) {
deprecated(
"An asynchronous reporter callback called its 'done' callback " +
'more than once. This is a bug in the reporter callback in ' +
'question. This will be treated as an error in a future version.',
'question. This will be treated as an error in a future ' +
'version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.',
{ ignoreRunnable: true }
);
}

4
src/core/Spec.js
View File

@@ -151,7 +151,9 @@ x */
"An asynchronous function called its 'done' " +
'callback more than once. This is a bug in the spec, beforeAll, ' +
'beforeEach, afterAll, or afterEach function in question. This will ' +
'be treated as an error in a future version.\n' +
'be treated as an error in a future version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.\n' +
'(in spec: ' +
self.getFullName() +
')',

8
src/core/Suite.js
View File

@@ -242,7 +242,9 @@ getJasmineRequireObj().Suite = function(j$) {
"An asynchronous function called its 'done' callback more than " +
'once. This is a bug in the spec, beforeAll, beforeEach, afterAll, ' +
'or afterEach function in question. This will be treated as an error ' +
'in a future version.\n' +
'in a future version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.\n' +
'(in suite: ' +
this.getFullName() +
')';
@@ -251,7 +253,9 @@ getJasmineRequireObj().Suite = function(j$) {
'A top-level beforeAll or afterAll function called its ' +
"'done' callback more than once. This is a bug in the beforeAll " +
'or afterAll function in question. This will be treated as an ' +
'error in a future version.';
'error in a future version. See' +
'<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> ' +
'for more information.';
}
this.env.deprecated(msg, { ignoreRunnable: true });