warren/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Default forbidDuplicateNames to true

Browse Source
This commit is contained in:
Steve Gravrock
2025-09-14 10:06:47 -07:00
parent 3040abe23d
commit 7c34b43607
5 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/jasmine-core/jasmine.js
View File

@@ -3345,9 +3345,9 @@ getJasmineRequireObj().Configuration = function(j$) {
* error.
* @name Configuration#forbidDuplicateNames
* @type boolean
* @default false
* @default true
*/
forbidDuplicateNames: false,
forbidDuplicateNames: true,
/**
* Whether to issue warnings for certain deprecated functionality
* every time it's used. If not set or set to false, deprecation warnings

2
spec/core/ConfigurationSpec.js
View File

@@ -25,7 +25,7 @@ describe('Configuration', function() {
expect(subject.specFilter()).toEqual(true);
expect(subject.hideDisabled).toEqual(false);
expect(subject.autoCleanClosures).toEqual(true);
expect(subject.forbidDuplicateNames).toEqual(false);
expect(subject.forbidDuplicateNames).toEqual(true);
expect(subject.verboseDeprecations).toEqual(false);
expect(subject.detectLateRejectionHandling).toEqual(false);
});

16
spec/core/EnvSpec.js
View File

@@ -487,14 +487,14 @@ describe('Env', function() {
it('does not throw an error when called in a describe', function() {
env.setParallelLoadingState('helpers');
check();
check(1);
env.setParallelLoadingState('specs');
check();
check(2);
function check() {
function check(disambiguator) {
let done = false;
env.describe('a suite', function() {
env.describe('a suite ' + disambiguator, function() {
expect(function() {
env.it('a spec');
env.beforeAll(function() {});
@@ -594,14 +594,14 @@ describe('Env', function() {
it('does not throw an error when called in a describe', function() {
env.setParallelLoadingState('helpers');
check();
check(1);
env.setParallelLoadingState('specs');
check();
check(2);
function check() {
function check(disambiguator) {
let done = false;
env.describe('a suite', function() {
env.describe('a suite ' + disambiguator, function() {
expect(function() {
env.it('a spec');
env.afterAll(function() {});

2
spec/core/integration/SpecRunningSpec.js
View File

@@ -40,7 +40,7 @@ describe('spec running', function() {
env.it('should run nested suites', function() {
foo++;
});
env.it('should run nested suites', function() {
env.it('should run nested suites 2', function() {
bar++;
});
});

4
src/core/Configuration.js
View File

@@ -95,9 +95,9 @@ getJasmineRequireObj().Configuration = function(j$) {
* error.
* @name Configuration#forbidDuplicateNames
* @type boolean
* @default false
* @default true
*/
forbidDuplicateNames: false,
forbidDuplicateNames: true,
/**
* Whether to issue warnings for certain deprecated functionality
* every time it's used. If not set or set to false, deprecation warnings