Properly record finishing an xdescribe so further cleanup works

Fix #724
This commit is contained in:
slackersoft
2014-12-09 12:40:00 -08:00
parent ba9c863de9
commit 8bb2f67fb3
3 changed files with 39 additions and 2 deletions

View File

@@ -634,8 +634,8 @@ getJasmineRequireObj().Env = function(j$) {
resultCallback: function(attrs) {
if (!suite.disabled) {
clearResourcesForRunnable(suite.id);
currentlyExecutingSuites.pop();
}
currentlyExecutingSuites.pop();
reporter.suiteDone(attrs);
}
});

View File

@@ -1122,6 +1122,43 @@ describe("Env integration", function() {
env.execute();
});
it('should report xdescribes as expected', function(done) {
var env = new j$.Env(),
reporter = jasmine.createSpyObj('fakeReporter', [
"jasmineStarted",
"jasmineDone",
"suiteStarted",
"suiteDone",
"specStarted",
"specDone"
]);
reporter.jasmineDone.and.callFake(function() {
expect(reporter.jasmineStarted).toHaveBeenCalledWith({
totalSpecsDefined: 1
});
expect(reporter.specDone).not.toHaveBeenCalled();
expect(reporter.suiteDone.calls.count()).toBe(3);
done();
});
env.addReporter(reporter);
env.describe("A Suite", function() {
env.describe("nested", function() {
env.xdescribe("xd out", function() {
env.it("with a spec", function() {
env.expect(true).toBe(false);
});
});
});
});
env.execute();
});
it("should be possible to get full name from a spec", function() {
var env = new j$.Env({global: { setTimeout: setTimeout }}),
topLevelSpec, nestedSpec, doublyNestedSpec;

View File

@@ -240,8 +240,8 @@ getJasmineRequireObj().Env = function(j$) {
resultCallback: function(attrs) {
if (!suite.disabled) {
clearResourcesForRunnable(suite.id);
currentlyExecutingSuites.pop();
}
currentlyExecutingSuites.pop();
reporter.suiteDone(attrs);
}
});