warren/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions 9 Packages Projects Releases Wiki Activity

refactor: replace deprecated String.prototype.substr()

Browse Source 
.substr() is deprecated so we replace it with functions which work similarily but aren't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
This commit is contained in:
Tobias Speicher
2022-03-25 16:03:46 +01:00
parent 1e0c312f9f
commit aa979277fb
6 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/jasmine-core/jasmine.js
View File

@@ -1042,7 +1042,7 @@ getJasmineRequireObj().Spec = function(j$) {
boilerplateEnd =
boilerplateStart + Spec.pendingSpecExceptionMessage.length;
return fullMessage.substr(boilerplateEnd);
return fullMessage.slice(boilerplateEnd);
};
Spec.pendingSpecExceptionMessage = '=> marked Pending';

4
spec/core/asymmetric_equality/ArrayContainingSpec.js
View File

@@ -58,8 +58,8 @@ describe('ArrayContaining', function() {
if (
typeof a == 'string' &&
typeof b == 'string' &&
a.substr(0, 3) == 'foo' &&
b.substr(0, 3) == 'foo'
a.slice(0, 3) == 'foo' &&
b.slice(0, 3) == 'foo'
) {
return true;
}

4
spec/core/asymmetric_equality/ArrayWithExactContentsSpec.js
View File

@@ -48,8 +48,8 @@ describe('ArrayWithExactContents', function() {
if (
typeof a == 'string' &&
typeof b == 'string' &&
a.substr(0, 3) == 'foo' &&
b.substr(0, 3) == 'foo'
a.slice(0, 3) == 'foo' &&
b.slice(0, 3) == 'foo'
) {
return true;
}

4
spec/core/asymmetric_equality/ObjectContainingSpec.js
View File

@@ -121,8 +121,8 @@ describe('ObjectContaining', function() {
if (
typeof a == 'string' &&
typeof b == 'string' &&
a.substr(0, 3) == 'foo' &&
b.substr(0, 3) == 'foo'
a.slice(0, 3) == 'foo' &&
b.slice(0, 3) == 'foo'
) {
return true;
}

4
spec/core/integration/CustomMatchersSpec.js
View File

@@ -81,8 +81,8 @@ describe('Custom Matchers (Integration)', function() {
if (
typeof a == 'string' &&
typeof b == 'string' &&
a.substr(0, 3) == 'foo' &&
b.substr(0, 3) == 'foo'
a.slice(0, 3) == 'foo' &&
b.slice(0, 3) == 'foo'
) {
return true;
}

2
src/core/Spec.js
View File

@@ -316,7 +316,7 @@ getJasmineRequireObj().Spec = function(j$) {
boilerplateEnd =
boilerplateStart + Spec.pendingSpecExceptionMessage.length;
return fullMessage.substr(boilerplateEnd);
return fullMessage.slice(boilerplateEnd);
};
Spec.pendingSpecExceptionMessage = '=> marked Pending';