warren/jasmine
1
0
Fork 0
Code Issues Pull Requests Actions 9 Packages Projects Releases Wiki Activity

Merge pull request #356 from sheelc/spec_titles

Browse Source 
Add titles to specs in HtmlReporter
This commit is contained in:
Davis W. Frank
2013-04-28 23:11:40 -07:00
parent dd8d3f9788 bf2adf55eb
commit baad5ff01f
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/jasmine-core/jasmine-html.js
View File

@@ -87,7 +87,8 @@ jasmine.HtmlReporter = function(options) {
symbols.appendChild(createDom("li", {
className: result.status,
id: "spec_" + result.id}
id: "spec_" + result.id,
title: result.fullName}
));
if (result.status == "failed") {

3
spec/html/HtmlReporterSpec.js
View File

@@ -46,12 +46,13 @@ describe("New HtmlReporter", function() {
});
reporter.initialize();
reporter.specDone({id: 789, status: "disabled"});
reporter.specDone({id: 789, status: "disabled", fullName: "symbols should have titles"});
var statuses = container.getElementsByClassName('symbol-summary')[0];
var specEl = statuses.getElementsByTagName('li')[0];
expect(specEl.getAttribute("class")).toEqual("disabled");
expect(specEl.getAttribute("id")).toEqual("spec_789");
expect(specEl.getAttribute("title")).toEqual("symbols should have titles");
});
it("reports the status symbol of a pending spec", function() {

3
src/html/HtmlReporter.js
View File

@@ -65,7 +65,8 @@ jasmine.HtmlReporter = function(options) {
symbols.appendChild(createDom("li", {
className: result.status,
id: "spec_" + result.id}
id: "spec_" + result.id,
title: result.fullName}
));
if (result.status == "failed") {