Compare commits

...

7 Commits

Author SHA1 Message Date
Gregg Van Hove
426eebe1ce bump version to 2.3.2 2015-05-07 14:02:12 -07:00
Gregg Van Hove
add841a1e9 A spec without a function provided should be pending not disabled
Fixes #840
2015-05-07 13:46:52 -07:00
Gregg Van Hove
023c998660 use a link for the PR in release notes 2015-05-05 07:51:49 -07:00
Gregg Van Hove
3dde7d0c29 Bump version to 2.3.1 to create a new bower package 2015-05-05 07:48:49 -07:00
Gregg Van Hove
4e3f9a4d09 Merge pull request #843 from evoL/fix-bower-package
Make the Bower package use browser-friendly files.
2015-05-05 07:22:25 -07:00
Rafał Hirsz
b89fbc71a7 Point Bower's main field to jasmine.js, which is browser-friendly. 2015-05-05 15:36:24 +02:00
Gregg Van Hove
4c0e3b2aed remove dist zips from the repo. They should all be available on github releases 2015-04-28 13:43:21 -07:00
24 changed files with 64 additions and 16 deletions

2
.gitignore vendored
View File

@@ -20,5 +20,5 @@ sauce_connect.log
*.swp
build/
*.egg-info/
dist/*.tar.gz
dist
nbproject/

View File

@@ -1,6 +1,6 @@
{
"name": "jasmine-core",
"version": "2.3.0",
"version": "2.3.2",
"homepage": "http://jasmine.github.io",
"authors": [
"slackersoft <gregg@slackersoft.net>"
@@ -14,7 +14,7 @@
],
"license": "MIT",
"moduleType": "globals",
"main": "lib/jasmine-core.js",
"main": "lib/jasmine-core/jasmine.js",
"ignore": [
"**/.*",
"dist",

Binary file not shown.

Binary file not shown.

Binary file not shown.

Binary file not shown.

Binary file not shown.

Binary file not shown.

Binary file not shown.

Binary file not shown.

Binary file not shown.

Binary file not shown.

Binary file not shown.

Binary file not shown.

Binary file not shown.

Binary file not shown.

View File

@@ -342,7 +342,7 @@ getJasmineRequireObj().Spec = function(j$) {
this.onStart(this);
if (!this.isExecutable() || enabled === false) {
if (!this.isExecutable() || this.markedPending || enabled === false) {
complete(enabled);
return;
}
@@ -419,7 +419,7 @@ getJasmineRequireObj().Spec = function(j$) {
};
Spec.prototype.isExecutable = function() {
return !this.disabled && !this.markedPending;
return !this.disabled;
};
Spec.prototype.getFullName = function() {
@@ -3294,5 +3294,5 @@ getJasmineRequireObj().interface = function(jasmine, env) {
};
getJasmineRequireObj().version = function() {
return '2.3.0';
return '2.3.2';
};

View File

@@ -4,6 +4,6 @@
#
module Jasmine
module Core
VERSION = "2.3.0"
VERSION = "2.3.2"
end
end

View File

@@ -1,7 +1,7 @@
{
"name": "jasmine-core",
"license": "MIT",
"version": "2.3.0",
"version": "2.3.2",
"repository": {
"type": "git",
"url": "https://github.com/jasmine/jasmine.git"

14
release_notes/2.3.1.md Normal file
View File

@@ -0,0 +1,14 @@
# Jasmine 2.3.1 Release Notes
## Summary
This release is a packaging update for bower only.
## Pull Requests & Issues
* Point Bower's main field to jasmine.js, which is browser-friendly.
- Merge [#843](https://github.com/jasmine/jasmine/issues/843) from @evoL
------
_Release Notes generated with _[Anchorman](http://github.com/infews/anchorman)_

14
release_notes/2.3.2.md Normal file
View File

@@ -0,0 +1,14 @@
# Jasmine 2.3.2 Release Notes
## Summary
This is a hotfix release to fix a regression with specs declared without a function body
## Pull Requests & Issues
* A spec without a function provided should be `pending` not `disabled`
- Fixes [#840](https://github.com/jasmine/jasmine/issues/840)
------
_Release Notes generated with _[Anchorman](http://github.com/infews/anchorman)_

View File

@@ -119,7 +119,6 @@ describe("Spec", function() {
queueRunnerFactory: fakeQueueRunner
});
expect(spec.status()).toBe('pending');
});
@@ -402,13 +401,13 @@ describe("Spec", function() {
expect(spec.isExecutable()).toBe(false);
});
it("should not be executable when pending", function() {
it("should be executable when pending", function() {
var spec = new j$.Spec({
queueableFn: { fn: function() {} }
});
spec.pend();
expect(spec.isExecutable()).toBe(false);
expect(spec.isExecutable()).toBe(true);
});
it("should be executable when not disabled or pending", function() {

View File

@@ -1134,6 +1134,27 @@ describe("Env integration", function() {
});
expect(reporter.specDone.calls.count()).toBe(5);
expect(reporter.specDone).toHaveBeenCalledWith(jasmine.objectContaining({
description: 'with a top level spec',
status: 'passed'
}));
expect(reporter.specDone).toHaveBeenCalledWith(jasmine.objectContaining({
description: "with an x'ed spec",
status: 'pending'
}));
expect(reporter.specDone).toHaveBeenCalledWith(jasmine.objectContaining({
description: 'with a spec',
status: 'failed'
}));
expect(reporter.specDone).toHaveBeenCalledWith(jasmine.objectContaining({
description: 'is pending',
status: 'pending'
}));
var suiteResult = reporter.suiteStarted.calls.argsFor(0)[0];
expect(suiteResult.description).toEqual("A Suite");
@@ -1147,7 +1168,7 @@ describe("Env integration", function() {
env.expect(true).toBe(true);
});
env.describe("with a nested suite", function() {
env.xit("with a pending spec", function() {
env.xit("with an x'ed spec", function() {
env.expect(true).toBe(true);
});
env.it("with a spec", function() {
@@ -1155,9 +1176,9 @@ describe("Env integration", function() {
});
});
env.describe('with only pending specs', function() {
env.describe('with only non-executable specs', function() {
env.it('is pending');
env.xit('is pending', function() {
env.xit('is xed', function() {
env.expect(true).toBe(true);
});
});

View File

@@ -50,7 +50,7 @@ getJasmineRequireObj().Spec = function(j$) {
this.onStart(this);
if (!this.isExecutable() || enabled === false) {
if (!this.isExecutable() || this.markedPending || enabled === false) {
complete(enabled);
return;
}
@@ -127,7 +127,7 @@ getJasmineRequireObj().Spec = function(j$) {
};
Spec.prototype.isExecutable = function() {
return !this.disabled && !this.markedPending;
return !this.disabled;
};
Spec.prototype.getFullName = function() {