warren/libiscsi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

configure: fix bogus TEST_CHAP_BASE64 conditional

Browse Source 
The conditional should be checking for gnutls presence.

On openSUSE Tumbleweed without gnutls this gives me:
  > ./test-tool/iscsi-test-cu --list|grep -i chap
  ALL.iSCSICHAP
  ALL.iSCSICHAP.Simple
  ALL.iSCSICHAP.Invalid
  iSCSI.iSCSICHAP
  iSCSI.iSCSICHAP.Simple
  iSCSI.iSCSICHAP.Invalid

Install gnutls, rebuild and check for base64 test presence:
  > sudo zypper in gnutls-devel

  > git clean -fxd .
  <rebuild>

  > ./test-tool/iscsi-test-cu --list|grep -i chap
  ALL.iSCSICHAP
  ALL.iSCSICHAP.Simple
  ALL.iSCSICHAP.Invalid
  ALL.iSCSICHAP.Base64
  ALL.iSCSICHAP.Base64Oversize
  iSCSI.iSCSICHAP
  iSCSI.iSCSICHAP.Simple
  iSCSI.iSCSICHAP.Invalid
  iSCSI.iSCSICHAP.Base64
  iSCSI.iSCSICHAP.Base64Oversize

Signed-off-by: David Disseldorp <ddiss@suse.de>
This commit is contained in:
David Disseldorp
2026-05-22 18:35:43 +10:00
parent 2d3c56082c
commit 114bbf00e1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
configure.ac
View File

@@ -109,7 +109,7 @@ if test "$WITH_LIBGCRYPT" != no; then
WITH_LIBGCRYPT=$ac_cv_lib_gcrypt_gcry_control
fi
# gnutls_base64_encode2() was added >8 years ago so should be present
AM_CONDITIONAL(TEST_CHAP_BASE64, [test "$WITH_LIBGCRYPT"])
AM_CONDITIONAL(TEST_CHAP_BASE64, [test "$WITH_GNUTLS" = yes])
NEED_MD5=no
if test "$WITH_GNUTLS" = no && test "$WITH_LIBGCRYPT" = no; then